After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771420 - [WK2] Printing an email does not work
[WK2] Printing an email does not work
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.21.x (obsolete)
Other Linux
: Normal major
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2016-09-14 11:01 UTC by Tomas Popela
Modified: 2016-09-15 08:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (19.69 KB, patch)
2016-09-14 11:11 UTC, Tomas Popela
accepted-commit_after_freeze Details | Review

Description Tomas Popela 2016-09-14 11:01:09 UTC
Printing an email in WK2 port of Evolution will result in blank page printed and various warnings printed in the console.
Comment 1 Tomas Popela 2016-09-14 11:11:44 UTC
Created attachment 335510 [details] [review]
Proposed patch
Comment 2 Milan Crha 2016-09-14 11:38:37 UTC
Review of attachment 335510 [details] [review]:

Looks good. Either commit for 3.22.0, if you receive an approval from the release-team, or right after it.
Comment 3 André Klapper 2016-09-14 12:00:57 UTC
Small typo in comment ("Builds an name"); just saying.
Comment 4 Tomas Popela 2016-09-14 12:15:34 UTC
(In reply to André Klapper from comment #3)
> Small typo in comment ("Builds an name"); just saying.

Thanks Andre for noticing.. I will correct it while committing the change.
Comment 5 Tomas Popela 2016-09-15 08:28:50 UTC
Fixed with the following commit:

    Bug 771420 - [WK2] Printing an email does not work
    
    Adapt the EMailPrinter to the WebKit2 API. While doing so port it from using
    GSimpleAsyncResult to GTask. Also we need to make some changes to EWebView as
    if the print dialog was showed and immediately closed several times in row then
    it could happen that the callbacks from EWebView could be called without a valid
    EWebView object. This was addressed by using the GWeakRef.

commit d71cf6f in the master branch for Evolution 3.22.0+