After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771401 - Calendar list in event entry is too small
Calendar list in event entry is too small
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: User Interface
3.21.x
Other Linux
: Normal normal
: 3.26
Assigned To: Ernestas Kulik
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-14 03:19 UTC by Mohammed Sadiq
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
new event quick add (image) (7.40 KB, image/png)
2016-09-14 03:19 UTC, Mohammed Sadiq 		  Details
quick-add-popover.ui: propagate children height in calendar list (1.14 KB, patch)
2016-09-14 06:52 UTC, Ernestas Kulik 		committed Details | Review
Calendar entry after current fix (video) (76.08 KB, video/webm)
2016-09-14 16:24 UTC, Mohammed Sadiq 		  Details

Description Mohammed Sadiq 2016-09-14 03:19:36 UTC 
Created attachment 335480 [details]
new event quick add (image)

The calendar list in event entry is too small. This wasn't present in gnome-calendar 3.20, but on master.

See attached screenshot.
Comment 1 Ernestas Kulik 2016-09-14 06:52:36 UTC 
Created attachment 335484 [details] [review]
quick-add-popover.ui: propagate children height in calendar list

Due to changes in GTK+, scrolled windows do not propagate the natural
sizes of their children by default, which results in a tiny calendar
list.
Comment 2 Ernestas Kulik 2016-09-14 06:53:48 UTC 
This also sets the maximum content height to 200 px, so it does not grow silly tall.
Comment 3 Georges Basile Stavracas Neto 2016-09-14 16:11:08 UTC 
Thanks for the fix!

Attachment 335484 [details] pushed as f11edee - quick-add-popover.ui: propagate children height in calendar list
Comment 4 Mohammed Sadiq 2016-09-14 16:24:19 UTC 
Created attachment 335545 [details]
Calendar entry after current fix (video)

This fix has to be improved.

Now when the list is selected, the dialog window size changes. This shouldn't happen, because a change in window size can cause glitches in ui.

See attached screencast.

Thank you.
Comment 5 Georges Basile Stavracas Neto 2016-09-14 16:30:18 UTC 
Tracking the size of the popover and adjusting the calendar list is a complex calc that depends on an untrackable ammount of variables. This is not feasible for 3.21.92 release, which will happen today.
Comment 6 Ernestas Kulik 2016-09-14 16:31:58 UTC 
The problem is due to the popover growing upwards, which is unrelated to this issue.
Comment 7 Mohammed Sadiq 2016-09-14 16:35:31 UTC 
Hm.. This bug wasn't present in version 3.20. Anyway I shall file a new bug later, if required.
Comment 8 Ernestas Kulik 2016-09-14 17:11:38 UTC 
Georges, your approach is way better. I shouldn’t have rushed it.