After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771392 - settings-daemon 3.21.92 buildfail in smartcard. Tarball issue?
settings-daemon 3.21.92 buildfail in smartcard. Tarball issue?
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: smartcard
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-13 21:39 UTC by Bjørn Lie
Modified: 2016-09-14 10:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
smartcard: Don't dist built sources (1.97 KB, patch)
2016-09-14 10:01 UTC, Kalev Lember
committed Details | Review

Description Bjørn Lie 2016-09-13 21:39:47 UTC
Trying to build new 3.21.92 version I get this buildfail.
I suspect the tarball is incorrectly made.

[  145s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.21.92/plugins/xsettings'
[  145s] Making all in smartcard
[  145s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.21.92/plugins/smartcard'
[  145s] make  all-am
[  145s] make[4]: Entering directory '/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.21.92/plugins/smartcard'
[  145s]   CC       libsmartcard_la-org.gnome.SettingsDaemon.Smartcard.lo
[  145s]   CC       libsmartcard_la-gsd-smartcard-enum-types.lo
[  145s]   CC       libsmartcard_la-gsd-smartcard-manager.lo
[  145s]   CC       libsmartcard_la-gsd-smartcard-plugin.lo
[  145s]   CC       libsmartcard_la-gsd-smartcard-service.lo
[  145s]   CC       libsmartcard_la-gsd-smartcard-utils.lo
[  145s]   CC       gsd_test_smartcard-org.gnome.SettingsDaemon.Smartcard.o
[  145s]   CC       gsd_test_smartcard-gsd-smartcard-enum-types.o
[  146s] gsd-smartcard-enum-types.c:7:105: fatal error: /home/hadess/Projects/jhbuild/gnome-settings-daemon/plugins/smartcard/gsd-smartcard-manager.h: No such file or directory
[  146s]  #include "/home/hadess/Projects/jhbuild/gnome-settings-daemon/plugins/smartcard/gsd-smartcard-manager.h"
[  146s]                                                                                                          ^
[  146s] compilation terminated.
[  146s] make[4]: *** [Makefile:785: gsd_test_smartcard-gsd-smartcard-enum-types.o] Error 1
[  146s] make[4]: *** Waiting for unfinished jobs....
[  146s] gsd-smartcard-enum-types.c:7:105: fatal error: /home/hadess/Projects/jhbuild/gnome-settings-daemon/plugins/smartcard/gsd-smartcard-manager.h: No such file or directory
[  146s]  #include "/home/hadess/Projects/jhbuild/gnome-settings-daemon/plugins/smartcard/gsd-smartcard-manager.h"
[  146s]                                                                                                          ^
[  146s] compilation terminated.
[  146s] make[4]: *** [Makefile:736: libsmartcard_la-gsd-smartcard-enum-types.lo] Error 1
[  148s] make[4]: Leaving directory '/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.21.92/plugins/smartcard'
[  148s] make[3]: *** [Makefile:559: all] Error 2
[  148s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.21.92/plugins/smartcard'
[  148s] make[2]: *** [Makefile:472: all-recursive] Error 1
[  148s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.21.92/plugins'
[  148s] make[1]: *** [Makefile:517: all-recursive] Error 1
[  148s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/gnome-settings-daemon-3.21.92'
[  148s] make: *** [Makefile:449: all] Error 2
[  148s] error: Bad exit status from /var/tmp/rpm-tmp.yvrhlk (%build)
[  148s] 
[  148s] 
[  148s] RPM build errors:
[  148s]     Bad exit status from /var/tmp/rpm-tmp.yvrhlk (%build)
[  148s] 
[  148s] lamb11 failed "build gnome-settings-daemon.spec" at Tue Sep 13 21:35:49 UTC 2016.
Comment 1 Bastien Nocera 2016-09-13 22:22:23 UTC
Unless your username is the same as mine, I'm stumped. Looks like some built files getting into the tarball...
Comment 2 Dominique Leuenberger 2016-09-14 08:26:16 UTC
(In reply to Bastien Nocera from comment #1)
> Unless your username is the same as mine, I'm stumped. Looks like some built
> files getting into the tarball...

And using the tarball it would be surprising if he built it inside jhbuild too
Comment 3 Kalev Lember 2016-09-14 10:01:21 UTC
Created attachment 335506 [details] [review]
smartcard: Don't dist built sources
Comment 4 Bastien Nocera 2016-09-14 10:45:58 UTC
Attachment 335506 [details] pushed as 56ac178 - smartcard: Don't dist built sources