After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771383 - rtprtxreceive: Sample pipeline uses obsolete rtx-payload-type parameter
rtprtxreceive: Sample pipeline uses obsolete rtx-payload-type parameter
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
git master
Other Linux
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-13 17:49 UTC by Marcin Lewandowski
Modified: 2017-03-17 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Marcin Lewandowski 2016-09-13 17:49:33 UTC
The sample pipeline for rtprtxreceive uses obsolete rtx-payload-type parameter.

It does not work with GStreamer 1.0.
Comment 1 Marcin Lewandowski 2016-09-13 17:50:44 UTC
Moreover, the second pipeline

gst-launch-1.0 rtpsession name=rtpsession \
        udpsrc port=5000 caps="application/x-rtp,media=(string)audio,clock-rate=(int)44100,encoding-name=(string)SPEEX,encoding-params=(string)1,octet-align=(string)1" ! \
            rtpsession.recv_rtp_sink \
            rtpsession.recv_rtp_src ! rtprtxreceive rtx-payload-types="99" ! rtpjitterbuffer do-retransmission=true ! rtpspeexdepay ! \
            speexdec ! audioconvert ! autoaudiosink \
        rtpsession.send_rtcp_src ! udpsink host="127.0.0.1" port=5001 \
        udpsrc port=5002 ! rtpsession.recv_rtcp_sink sync=fakse async=false

throws syntax error and has a typo (sync=fakse at the end)
Comment 2 Marcin Lewandowski 2016-09-13 18:36:10 UTC
I was trying to figure out proper pipelines but I got stuck with

gst-launch-1.0 -v -m rtpsession name=rtpsession \
        audiotestsrc ! audioconvert ! audioresample ! opusenc ! rtpopuspay ! rtprtxsend payload-type-map=map,96=97 ! \
            identity drop-probability=0.1 ! rtpsession.send_rtp_sink \
            rtpsession.send_rtp_src ! udpsink host="127.0.0.1" port=5000 \
        udpsrc port=5001 ! rtpsession.recv_rtcp_sink \
        rtpsession.send_rtcp_src ! udpsink host="127.0.0.1" port=5002 sync=false async=false



gst-launch-1.0 -v -m rtpsession name=rtpsession \
        udpsrc port=5000 caps="application/x-rtp, media=(string)audio, clock-rate=(int)48000, encoding-name=(string)OPUS, payload=(int)96" ! \
            rtpsession.recv_rtp_sink \
            rtpsession.recv_rtp_src ! rtprtxreceive payload-type-map=map,96=97 ! rtpjitterbuffer do-retransmission=true ! rtpopusdepay ! \
            opusdec ! audioconvert ! audioresample ! autoaudiosink \
        rtpsession.send_rtcp_src ! udpsink host="127.0.0.1" port=5001 sync=false async=false \
        udpsrc port=5002 ! rtpsession.recv_rtcp_sink



Still getting drops. Seems that rtpsession is not sending NACKs (such info is shown in GST_DEBUG=rtpsession:5 log). Any hints?
Comment 3 Marcin Lewandowski 2016-09-14 13:46:49 UTC
This seems to be related to bug #758719
Comment 4 George Kiagiadakis 2017-03-17 17:11:52 UTC
commit ba606b96d3fa09afe0530b5b5f843a3dacfcbd56
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Thu Mar 16 18:20:54 2017 +0200

    rtprtxreceive: fix example pipelines and improve the documentation
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771383