After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771382 - dvbsuboverlay: map with READWRITE for overlay blend
dvbsuboverlay: map with READWRITE for overlay blend
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.9.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 766978
 
 
Reported: 2016-09-13 17:46 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-09-30 07:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dvbsuboverlay: map with READWRITE for overlay blend (1.46 KB, patch)
2016-09-13 17:47 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review
videooverlaycomposition: document required map flags (1.61 KB, patch)
2016-09-14 08:19 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-09-13 17:46:59 UTC 
Just as in basetextoverlay [1], the frame to blend with the subtitles overlay
should be mapped with flags GST_MAP_READWRITE, because
gst_video_overlay_composition_blend() does both operations.

1. https://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=1396f804

Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Comment 1 Víctor Manuel Jáquez Leal 2016-09-13 17:47:03 UTC 
Created attachment 335465 [details] [review]
dvbsuboverlay: map with READWRITE for overlay blend
Comment 2 Tim-Philipp Müller 2016-09-13 17:54:15 UTC 
Should probably also go into 1.8.
Comment 3 Víctor Manuel Jáquez Leal 2016-09-14 08:19:12 UTC 
Created attachment 335493 [details] [review]
videooverlaycomposition: document required map flags

Fix documentation for gst_video_overlay_composition_blend(). The video frame
needs to be mapped with GST_MAP_READWRITE flag.
Comment 4 Víctor Manuel Jáquez Leal 2016-09-14 08:58:15 UTC 
Comment on attachment 335465 [details] [review]
dvbsuboverlay: map with READWRITE for overlay blend

Attachment 335465 [details] pushed as 4ba54b6 - dvbsuboverlay: map with READWRITE for overlay blend
Comment 5 Tim-Philipp Müller 2016-09-14 09:10:12 UTC 
Comment on attachment 335493 [details] [review]
videooverlaycomposition: document required map flags

You should feel free to push doc updates directly (unless you want review of course) :)
Comment 6 Víctor Manuel Jáquez Leal 2016-09-14 09:12:24 UTC 
(In reply to Tim-Philipp Müller from comment #5)
> Comment on attachment 335493 [details] [review] [review]
> videooverlaycomposition: document required map flags
> 
> You should feel free to push doc updates directly (unless you want review of
> course) :)

As a non native English speaker, of course I want peer review :)
Comment 7 Víctor Manuel Jáquez Leal 2016-09-14 09:12:43 UTC 
(In reply to Tim-Philipp Müller from comment #2)
> Should probably also go into 1.8.

I'm going to push it to branch 1.8 too
Comment 8 Víctor Manuel Jáquez Leal 2016-09-14 09:22:11 UTC 
Attachment 335493 [details] pushed as dcfc69a - videooverlaycomposition: document required map flags