After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771347 - Evolution's mail composer underlines my message even when spell checking is disabled
Evolution's mail composer underlines my message even when spell checking is d...
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Composer
3.20.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Tomas Popela
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2016-09-13 08:35 UTC by Timur Kristóf
Modified: 2016-09-20 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for WebKit1 (Evolution < 3.22) (1.09 KB, patch)
2016-09-20 12:11 UTC, Tomas Popela 		none Details | Review

Description Timur Kristóf 2016-09-13 08:35:00 UTC 
I use evolution-3.20.5-1.fc24.x86_64 on latest Fedora 24.

In Edit -> Preferences -> Composer -> Spell checking, the "Check spelling while I type" option is disabled. Still, when I compose a reply to an email, most of the words in the email are underlined with red.
Comment 1 Tomas Popela 2016-09-20 12:00:37 UTC 
Fixed with the following commit:

    Bug 771347 - Evolution's mail composer underlines my message even when spell checking is disabled
    
    When doing reply don't forgot to turn off spell checking if it is disabled.
    Also remove a code that was accidentally committed that was preventing the spell
    check to perform.

commit edb6656 in the master branch for Evolution 3.23.1+

commit 02e857c in the gnome-3-22 branch for Evolution 3.22.1+
Comment 2 Timur Kristóf 2016-09-20 12:02:02 UTC 
Thank you Thomas, would it be possible to backport this fix to 3.20?
Comment 3 Tomas Popela 2016-09-20 12:06:52 UTC 
Hi Timur,

(In reply to Timur Kristóf from comment #2)
> Thank you Thomas, would it be possible to backport this fix to 3.20?

It's not a problem to backport it, but the thing is that there won't be any new 3.20 release for Evolution. But I can attach a patch for 3.20 branch here and you can ask your distribution to backport it downstream.
Comment 4 Tomas Popela 2016-09-20 12:11:26 UTC 
Created attachment 335927 [details] [review]
Patch for WebKit1 (Evolution < 3.22)