GNOME Bugzilla – Bug 771290
app window grows with each start due to incorrectly using gtk API (wayland)
Last modified: 2018-05-22 13:15:45 UTC
Description of problem: Since gtk3-3.21.5-1.fc25.x86_64 gitg window grows with each start (on wayland). You can see the same issue with virt-manager here: https://www.youtube.com/watch?v=NO6Wlaoq0x8 (the same issue applies to gitg) This has been reported against gtk: https://bugzilla.gnome.org/show_bug.cgi?id=771112 and determined as an application bug: https://bugzilla.gnome.org/show_bug.cgi?id=771112#c7 Quoting how to fix this: ~~~ https://wiki.gnome.org/HowDoI/SaveWindowState Querying the window size and then setting it with GtkWindow API is perfectly fine. Querying the window size with GtkWidget API and then setting it with GtkWindow API, *or* querying the window size with GtkWindow API and then setting it with GtkWidget API, is *not* okay, and only worked up until now with server-side decorations only on X11. ~~~ Version-Release number of selected component (if applicable): gitg-3.21.91-1.fc25.x86_64 gtk3-3.21.5-1.fc25.x86_64 How reproducible: always Steps to Reproduce: 1. start and close gitg repeatedly, it will grow each time
Created attachment 337289 [details] [review] Fix window growing each start As described in bug 771290, the window got slightly larger each time gitg was run. This was due to the way we accidentally mixed APIs when saving/restoring the window size. To fix this, use GtkWindow methods when saving the window size. This is consistent with our prior use of GtkWindow methods to set the window size on startup.
Excuse me, but I submitted a patch that fixes this bug over a year ago, it still applies cleanly to master, but it hasn't been reviewed and the bug still exists. It's rather disheartening as someone who wants to get more involved with GNOME to have patches that are nearly trivial in size just ignored. Could someone please review the patch so this bug can be closed?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gitg/issues/56.