After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771272 - jackaudiosink: hangs when jackd changes sample rate and/or buffer size
jackaudiosink: hangs when jackd changes sample rate and/or buffer size
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.8.1
Other Linux
: Normal normal
: 1.9.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-12 08:05 UTC by Thomas Scheuermann
Modified: 2016-09-30 07:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Call jack_shutdown_cb when jack_sample_rate_cb or jack_buffer_size_cb is called. (1.29 KB, patch)
2016-09-12 08:05 UTC, Thomas Scheuermann
none Details | Review
Call jack_shutdown_cb when jack_sample_rate_cb or jack_buffer_size_cb is called. (1.72 KB, patch)
2016-09-13 10:05 UTC, Thomas Scheuermann
committed Details | Review

Description Thomas Scheuermann 2016-09-12 08:05:07 UTC
Created attachment 335339 [details] [review]
Call jack_shutdown_cb when jack_sample_rate_cb or jack_buffer_size_cb is called.

If jackd changes the buffer size or sample rate, jackaudiosink hangs and can't be stopped. This also happens if jack is configured as slave and a gstreamer pipeline is started on the slvae machine while the jack master isn't running yet. If the the jack master is started it changes the buffer size / sample rate and jackaudiosink can't be stopped.
Comment 1 Sebastian Dröge (slomo) 2016-09-13 09:11:08 UTC
Comment on attachment 335339 [details] [review]
Call jack_shutdown_cb when jack_sample_rate_cb or jack_buffer_size_cb is called.

Looks good but can you add some more information to the commit message, like why we error out there and why calling shutdown there is solving your problem and what that problem is exactly?

You write all that in the bug report, but it would be good to have that in GIT too :)
Comment 2 Thomas Scheuermann 2016-09-13 10:05:33 UTC
Created attachment 335428 [details] [review]
Call jack_shutdown_cb when jack_sample_rate_cb or jack_buffer_size_cb is called.

Added more information to the commit message.
Comment 3 Sebastian Dröge (slomo) 2016-09-13 12:20:25 UTC
commit 1215849e69114516c93144ca590db2d751eebce7
Author: Thomas Scheuermann <Thomas.Scheuermann@barco.com>
Date:   Fri Sep 9 15:36:12 2016 +0200

    jack: Fix pipeline hang when jack changes sample rate or buffer size
    
    If jackd changes the buffer size or sample rate, jackaudiosink hangs
    and can't be stopped. This also happens if jack is configured as slave
    and a gstreamer pipeline is started on the slave machine while the jack
    master isn't running yet. If the the jack master is started it changes
    the buffer size / sample rate and jackaudiosink can't be stopped.
    
    This fix calls jack_shutdown_cb when jack_sample_rate_cb or
    jack_buffer_size_cb is called.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771272