After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771249 - Static playlists should not be removed using the Delete key
Static playlists should not be removed using the Delete key
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.20.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-11 15:36 UTC by Konstantin Pospelov
Modified: 2016-09-12 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to ignore static playlists when pressing Delete (1.81 KB, patch)
2016-09-11 15:59 UTC, Konstantin Pospelov 		committed Details | Review

Description Konstantin Pospelov 2016-09-11 15:36:09 UTC 
The Delete action is disabled for static playlists, however there is an inconsistency, because it's still possible to remove such a playlist using the Delete key.

Repro:
1. Open Playlists
2. Select Favorite Songs
3. Press the Delete key

Expected: nothing happens (not sure about this, maybe a popup with an appropriate message should be shown)
Actual: the playlist disappears from the list.
Comment 1 Konstantin Pospelov 2016-09-11 15:59:35 UTC 
Created attachment 335312 [details] [review]
Patch to ignore static playlists when pressing Delete
Comment 2 Marinus Schraal 2016-09-11 20:55:28 UTC 
Review of attachment 335312 [details] [review]:

lgtm
Comment 3 Marinus Schraal 2016-09-12 10:36:08 UTC 
Thanks for the nice catch + patch.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.