After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771232 - right click menu items are insensitive in terminal
right click menu items are insensitive in terminal
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-11 08:46 UTC by Mohammed Sadiq
Modified: 2016-11-22 23:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
egg-widget-action-group: don't leak signal id array (889 bytes, patch)
2016-11-22 23:34 UTC, Christian Hergert
committed Details | Review
egg-widget-action-group: add runtime warning (886 bytes, patch)
2016-11-22 23:34 UTC, Christian Hergert
committed Details | Review
egg-widget-action-group: fix signal discovery (2.00 KB, patch)
2016-11-22 23:35 UTC, Christian Hergert
committed Details | Review

Description Mohammed Sadiq 2016-09-11 08:46:18 UTC
In the terminal window, menu items in the right click menu are grayed out.
Comment 1 sébastien lafargue 2016-09-11 13:06:38 UTC
Confirmed regression, it was working before.
Comment 2 Don McComb 2016-11-22 13:15:41 UTC
I suspect that the issue was introduced with the following commit:
https://git.gnome.org/browse/gnome-builder/commit/?id=5736d4bfe365b6dee17d1eba30abfbbf8c3a7a99

I checked out this commit and the one before.  The one before was working.  This commit was not.
Comment 3 Christian Hergert 2016-11-22 22:44:32 UTC
Thanks for tracking this down, I'll take a look.
Comment 4 Christian Hergert 2016-11-22 23:34:53 UTC
Created attachment 340564 [details] [review]
egg-widget-action-group: don't leak signal id array

These are transfer-full, so we are responsible for freeing.
Comment 5 Christian Hergert 2016-11-22 23:34:57 UTC
Created attachment 340565 [details] [review]
egg-widget-action-group: add runtime warning
Comment 6 Christian Hergert 2016-11-22 23:35:03 UTC
Created attachment 340566 [details] [review]
egg-widget-action-group: fix signal discovery

First off, we were looking up the wrong object (the action group, not the
actual widget) and second, we need to walk the parent hierarchy as the
list_ids only gives us the signals at that specific TypeNode in GObject.
Comment 7 Christian Hergert 2016-11-22 23:35:49 UTC
Attachment 340564 [details] pushed as afa0d4e - egg-widget-action-group: don't leak signal id array
Attachment 340565 [details] pushed as 354d095 - egg-widget-action-group: add runtime warning
Attachment 340566 [details] pushed as 4da74cb - egg-widget-action-group: fix signal discovery