GNOME Bugzilla – Bug 771225
Bijiben fails to build
Last modified: 2017-05-24 01:16:17 UTC
Bijiben can't be compiled on jhbuild. Builds fine when not using jhbuild, using make command. The relevant error from log: /home/sadiq/jhbuild/checkout/bijiben/src/libbiji/provider/biji-provider.c:30:32: fatal error: ../biji-marshalers.h: No such file or directory #include "../biji-marshalers.h" ^
There are also some issues when compiling that are now treated as errors due to AX_COMPILER_FLAGS addition. Those are happening when not using jhbuild.
Created attachment 351449 [details] [review] declared note changed callback as static
Created attachment 351450 [details] [review] added const qualifier to return type
Created attachment 351451 [details] [review] fixed editor set selection switch
Created attachment 351452 [details] [review] fixed toggle block format switch
Created attachment 351453 [details] [review] fixed mixed declarations and code
Created attachment 351454 [details] [review] added not covered cases to switch
Created attachment 351455 [details] [review] add explicit code for cases covered by default
Created attachment 351456 [details] [review] add explicit code for missing case
Created attachment 351457 [details] [review] removed unused constructor code
Created attachment 351458 [details] [review] fixed const qualifier discard message
Created attachment 351459 [details] [review] stop using deprecated function
Created attachment 351460 [details] [review] removed unused constructor code
Created attachment 351461 [details] [review] add explicit code for missing case
Created attachment 351462 [details] [review] replaced deprecated functions
Created attachment 351463 [details] [review] removed trailing whitespaces
Created attachment 351464 [details] [review] replaced deprecated function
Created attachment 351465 [details] [review] replaced deprecated function
Review of attachment 351449 [details] [review]: Looks good. Pushed to master as commit 812448a3c62c3dd17f954a8219b802afc2d693f5.
Review of attachment 351450 [details] [review]: Pushed to master as commit 59540468524d86524f51bd08fd7702a38a0aa4b1.
Review of attachment 351451 [details] [review]: looks good.
Review of attachment 351452 [details] [review]: Looks good to me.
Review of attachment 351453 [details] [review]: Looks good.
Review of attachment 351454 [details] [review]: Looks good to me.
Review of attachment 351455 [details] [review]: ::: src/bjb-main-toolbar.c @@ +1018,3 @@ + case BJB_WINDOW_BASE_SPINNER_VIEW: + case BJB_WINDOW_BASE_ERROR_TRACKER: + case BJB_WINDOW_BASE_NO_VIEW: I suggest adding "break;" in every case even it doesn't do anything in that case. The same as some previous patches. I forgot to mention this.
IMHO, this way does help on identifying what those options really do. Without any break you know that their behaiour would be the same. If you add a break, you are suggesting that they are going to have a different behavior, at least sometime in the future. Anyway, almost in every case that the compiler suggested that those missing should be added, I wondered myself if they should be removed, at least until they have some real behavior, though I didn't have any proof about what they actually do, so I kept those.
Review of attachment 351457 [details] [review]: Looks good to me.
Review of attachment 351458 [details] [review]: Looks good.
Review of attachment 351459 [details] [review]: Looks good.
Review of attachment 351460 [details] [review]: Looks good.
Review of attachment 351461 [details] [review]: ::: src/bjb-window-base.c @@ +551,1 @@ + case BJB_WINDOW_BASE_NO_VIEW: Add "break;" in this case as described before.
Review of attachment 351462 [details] [review]: Looks good.
Review of attachment 351456 [details] [review]: ::: src/bjb-empty-results-box.c @@ +163,3 @@ break; + case BJB_EMPTY_RESULTS_TYPE: The same as what's mentioned previously. Add "break;".
Review of attachment 351463 [details] [review]: Looks good.
Review of attachment 351464 [details] [review]: ::: src/bjb-app-menu.c @@ +128,3 @@ GError *error = NULL; + + gtk_show_uri_on_window (gtk_application_get_active_window (user_data), one more useless space before "(" @@ +130,3 @@ + gtk_show_uri_on_window (gtk_application_get_active_window (user_data), + "help:bijiben", + gtk_get_current_event_time (), use GDK_CURRENT_TIME macro directly to get the current time.
Created attachment 351963 [details] [review] Replaced gtk_get_current_event_time for GDK_CURRENT_TIME Replaced gtk_get_current_event_time for GDK_CURRENT_TIME.
(In reply to Jonathan Kang from comment #36) > Review of attachment 351464 [details] [review] [review]: > > ::: src/bjb-app-menu.c > @@ +128,3 @@ > GError *error = NULL; > + > + gtk_show_uri_on_window (gtk_application_get_active_window (user_data), > > one more useless space before "(" > > @@ +130,3 @@ > + gtk_show_uri_on_window (gtk_application_get_active_window (user_data), > + "help:bijiben", > + gtk_get_current_event_time (), > > use GDK_CURRENT_TIME macro directly to get the current time. I have updated the patch regarding GDK_CURRENT_TIME. I don't get what do you mean about the useless space.
Review of attachment 351465 [details] [review]: ::: src/libbiji/editor/biji-webkit-editor.c @@ +353,3 @@ return FALSE; + gtk_show_uri_on_window (NULL, WebKitWebView is an implementation of GtkWidget, so calling gtk_widget_get_toplevel to get the toplevel window should be enough.
(In reply to Iñigo Martínez from comment #38) > > I have updated the patch regarding GDK_CURRENT_TIME. I don't get what do you > mean about the useless space. There are two spaces instead of one right after "gtk_show_uri_on_window". It should be "gtk_show_uri_on_window ()" instead of "gtk_show_uri_on_window ()".
Created attachment 352012 [details] [review] replaced deprecated function Fixed useless space.
Created attachment 352013 [details] [review] replaced deprecated function Use gtk_widget_get_toplevel to get the top level window when showing an uri.
(In reply to Jonathan Kang from comment #40) > (In reply to Iñigo Martínez from comment #38) > > > > I have updated the patch regarding GDK_CURRENT_TIME. I don't get what do you > > mean about the useless space. > > There are two spaces instead of one right after "gtk_show_uri_on_window". > > It should be "gtk_show_uri_on_window ()" instead of > "gtk_show_uri_on_window ()". I haven't seen it. I have fixed it now, thanks! I have also changed the issue regarding gtk_widget_get_toplevel.
Review of attachment 352012 [details] [review]: Looks good.
Review of attachment 352013 [details] [review]: Looks good.
Comment on attachment 351451 [details] [review] fixed editor set selection switch Pushed to master as commit 5be656f70a2b02acf055112f2762ed6bf5fa7f46.
Comment on attachment 351452 [details] [review] fixed toggle block format switch Pushed to master as commit 533c0f6a7207a0a72083734c16ec603784c50804.
Comment on attachment 351453 [details] [review] fixed mixed declarations and code Pushed to master as commit f55eefec841486a448a9f29cae7baaf1440c0b33.
Comment on attachment 351454 [details] [review] added not covered cases to switch Pushed to master as commit 45ea3f63580cfbedb22ff781522c3f952078bb03.
Comment on attachment 351455 [details] [review] add explicit code for cases covered by default Pushed to master as commit 0461a0150d15d844faf0ad98c24f7fce05784a39.
Comment on attachment 351456 [details] [review] add explicit code for missing case Pushed to master as commit 6e781feb7ce06a13c3d618a0f661beb1f876b34e.
Comment on attachment 351457 [details] [review] removed unused constructor code Rebased with attachment#351460 [details] into one commit and pushed to master as commit 1b1abc27ba04998439eca3c394100ee293f99c0b.
Comment on attachment 351460 [details] [review] removed unused constructor code Rebased with attachment#351457 [details] into one commit and pushed to master as commit 1b1abc27ba04998439eca3c394100ee293f99c0b.
Comment on attachment 351458 [details] [review] fixed const qualifier discard message Pushed to master as commit 0d2a4292283d183e7841bae31cf9e1da5ff2061f.
Comment on attachment 351459 [details] [review] stop using deprecated function Pushed to master as commit 1f04ac55ca027e9a571ca91d79d67acd0726c056.
Comment on attachment 351461 [details] [review] add explicit code for missing case Pushed to master as commit 2b7386a485ea4bef81d5246d96e6f19f71784f0e.
Comment on attachment 351462 [details] [review] replaced deprecated functions Pushed to master as commit da294bd800e8fac886039993e12a8d0c0a1e2d53.
Comment on attachment 351463 [details] [review] removed trailing whitespaces Pushed to master as commit 79688a38ce6cd4ab876262a2102f97422a92104e.
Comment on attachment 352013 [details] [review] replaced deprecated function Rebased with attachment#352012 [details] into one commit and pushed to master as commit 5ff688e564ea2d17be4b4836307ce9c27f10c606.
Comment on attachment 352012 [details] [review] replaced deprecated function Rebased with attachment#352013 [details] into one commit and pushed to master as commit 5ff688e564ea2d17be4b4836307ce9c27f10c606.