After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771187 - Add vala bindings
Add vala bindings
Status: RESOLVED FIXED
Product: gnome-autoar
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Autoar maintainer(s)
GNOME Autoar maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-09-10 13:59 UTC by Rico Tzschichholz
Modified: 2016-12-06 07:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add vala support and generate and install bindings (3.53 KB, patch)
2016-09-10 13:59 UTC, Rico Tzschichholz 		none Details | Review
Add vala support and generate and install bindings (3.63 KB, patch)
2016-11-27 17:58 UTC, Rico Tzschichholz 		committed Details | Review

Description Rico Tzschichholz 2016-09-10 13:59:14 UTC 
Build vala-bindings from the already available introspection data.
Comment 1 Rico Tzschichholz 2016-09-10 13:59:39 UTC 
Created attachment 335251 [details] [review]
Add vala support and generate and install bindings
Comment 2 Ting-Wei Lan 2016-11-27 16:22:21 UTC 
Review of attachment 335251 [details] [review]:

::: Makefile.am
@@ +191,3 @@
+gnome_autoar_gnome_autoar_gtk_@LIBGNOME_AUTOAR_API_VERSION@_vapi_VAPIDIRS = $(builddir)/gnome-autoar
+gnome_autoar_gnome_autoar_gtk_@LIBGNOME_AUTOAR_API_VERSION@_vapi_METADATADIRS = $(srcdir)/gnome-autoar
+gnome_autoar_gnome_autoar_gtk_@LIBGNOME_AUTOAR_API_VERSION@_vapi_FILES = gnome-autoar/GnomeAutoarGtk-0.1.gir

VAPIGEN gnome-autoar/gnome-autoar-gtk-0.vapi
error: Package `GnomeAutoar-0.1' not found in specified Vala API directories or GObject-Introspection GIR directories

I think you need _GIRDIRS here.
Comment 3 Rico Tzschichholz 2016-11-27 17:58:46 UTC 
Created attachment 340854 [details] [review]
Add vala support and generate and install bindings
Comment 4 Ting-Wei Lan 2016-12-01 10:16:48 UTC 
Review of attachment 340854 [details] [review]:

Nice, I don't see build issues now.
Comment 5 Ting-Wei Lan 2016-12-06 07:42:21 UTC 
Attachment 340854 [details] pushed as bd1f5bd - Add vala support and generate and install bindings