After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771170 - GIR files are generated in the source dir
GIR files are generated in the source dir
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: retro-gtk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-10 10:13 UTC by Adrien Plazas
Modified: 2016-09-10 10:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Remove GIR rules from Vala flags (1.31 KB, patch)
2016-09-10 10:15 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-09-10 10:13:45 UTC 
There are two rules to generate each GIR file and they all are generatedin the srcdir instead of the builddir.

Here are the warnings for retro-gobject:
/home/kekun/JHBuild/install/share/gobject-introspection-1.0/Makefile.introspection:155: Recipe was specified for file 'Retro-0.6.gir' at Makefile:901,
/home/kekun/JHBuild/install/share/gobject-introspection-1.0/Makefile.introspection:155: but 'Retro-0.6.gir' is now considered the same file as '/home/kekun/JHBuild/checkout/retro-gtk/retro-gobject/Retro-0.6.gir'.
/home/kekun/JHBuild/install/share/gobject-introspection-1.0/Makefile.introspection:155: Recipe for '/home/kekun/JHBuild/checkout/retro-gtk/retro-gobject/Retro-0.6.gir' will be ignored in favor of the one for 'Retro-0.6.gir'.

And here are the warnings for retro-gtk:
/home/kekun/JHBuild/install/share/gobject-introspection-1.0/Makefile.introspection:155: Recipe was specified for file 'RetroGtk-0.6.gir' at Makefile:753,
/home/kekun/JHBuild/install/share/gobject-introspection-1.0/Makefile.introspection:155: but 'RetroGtk-0.6.gir' is now considered the same file as '/home/kekun/JHBuild/checkout/retro-gtk/retro-gtk/RetroGtk-0.6.gir'.
/home/kekun/JHBuild/install/share/gobject-introspection-1.0/Makefile.introspection:155: Recipe for '/home/kekun/JHBuild/checkout/retro-gtk/retro-gtk/RetroGtk-0.6.gir' will be ignored in favor of the one for 'RetroGtk-0.6.gir'.
Comment 1 Adrien Plazas 2016-09-10 10:14:37 UTC 
Also, this prevents retro-gtk to compile with srcdir != builddir.
Comment 2 Adrien Plazas 2016-09-10 10:15:08 UTC 
Created attachment 335234 [details] [review]
build: Remove GIR rules from Vala flags

This avoids a double definition of the GIR file creation rules, once
correctly via Automake, once incorrectly via the Vala rules.

This allows the GIR files to land in the builddir rather than the
srcdir.
Comment 3 Adrien Plazas 2016-09-10 10:45:04 UTC 
Attachment 335234 [details] pushed as d181d6b - build: Remove GIR rules from Vala flags