After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771167 - Bigger fonts in file open popover
Bigger fonts in file open popover
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-10 09:49 UTC by Mohammed Sadiq
Modified: 2016-09-23 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gedit file open popover (image) (20.43 KB, image/png)
2016-09-10 09:49 UTC, Mohammed Sadiq 		  Details
Proposed patch (3.46 KB, patch)
2016-09-23 05:58 UTC, Jürg Billeter 		committed Details | Review

Description Mohammed Sadiq 2016-09-10 09:49:16 UTC 
Created attachment 335232 [details]
gedit file open popover (image)

Text in file open popover is a bit bigger. The font size for search entry text and the result list should be the same.

See the attachment.
Comment 1 Jürg Billeter 2016-09-22 16:49:57 UTC 
I can confirm this with GTK+/gedit 3.22.0 when text scaling is enabled (gnome-tweak-tool -> Fonts -> Scaling Factor). The font in the open doc selector is scaled twice, as far as I can tell. E.g., with a scaling factor 1.5, you get text that is scaled by factor 2.25.

https://git.gnome.org/browse/gedit/commit/?id=28028555d18c3be0a9adb8c800472d63749c5c63

I suspect 96.0 in the above commit should be replaced by the GTK CSS DPI value. Or maybe there is a way to directly use the size in pixels with GtkCellRendererText.
Comment 2 Jürg Billeter 2016-09-23 05:58:17 UTC 
Created attachment 336139 [details] [review]
Proposed patch

The attached patch works for me.
Comment 3 Paolo Borelli 2016-09-23 15:31:49 UTC 
Review of attachment 336139 [details] [review]:

Minor nitpick below, but other than that feel free to push thanks.

I am happy to see the magic numbers dosappear

::: gedit/gedit-open-document-selector.c
@@ +719,3 @@
 	}
 
+	if (selector->name_font)

You can use g_clear_pointer to shorten the whole patch a bit
Comment 4 Jürg Billeter 2016-09-23 16:55:31 UTC 
Comment on attachment 336139 [details] [review]
Proposed patch

Thanks for the review. Pushed with g_clear_pointer.

commit be621916ab616e070c4e49127c88d5b945d2f53d
Author: Jürg Billeter <j@bitron.ch>
Date:   Thu Sep 22 18:18:08 2016 +0200

    Fix open doc selector font size with text scaling
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771167