After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771158 - Build fails with --disable-tracker
Build fails with --disable-tracker
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: 3.22
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-10 06:52 UTC by Garrett Regier
Modified: 2016-09-12 19:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
batch-renaming: disable if compiled without tracker (3.61 KB, patch)
2016-09-12 19:00 UTC, Carlos Soriano
committed Details | Review

Description Garrett Regier 2016-09-10 06:52:02 UTC
nautilus-batch-rename-utilities.h:24:28: fatal error: tracker-sparql.h: No such file or directory
Comment 1 Carlos Soriano 2016-09-12 08:17:35 UTC
oh, right... I'm not sure having optional tracker makes much sense anymore for Nautilus, at least batch renaming we announce several features that wouldn't be possible without it.

Remind me (maybe Cosimo), why is having a hard-dep on tracker a problem?
Comment 2 Carlos Soriano 2016-09-12 19:00:13 UTC
Created attachment 335391 [details] [review]
batch-renaming: disable if compiled without tracker

We have a compile option to not use tracker. Batch renaming relies on
tracker for part of its functionality, and disabling that would mess the
code with ifdefs.

I think doesn't make much sense to have a compile time switch for
tracker anymore (tracker can still be disabled in runtime and it's fine)
so I would like to remove that switch.

Since it's late in the cycle, better to not do that, but let's try for
next release. For now just make the batch-renaming disabled in case
the compilation was done without tracker.
Comment 3 Carlos Soriano 2016-09-12 19:58:55 UTC
Attachment 335391 [details] pushed as 70dda95 - batch-renaming: disable if compiled without tracker