GNOME Bugzilla – Bug 771153
Project list: don't show 'Other projects' when there isn't any.
Last modified: 2017-01-22 16:14:20 UTC
In the view that lists projects, the list sometimes show 'Other projects' title when there isn't any. How to reproduce: 1. Open GNOME builder. (There shouldn't be projects below 'Other projects', so that it won't be shown) 2. Click select project for removal button (the tick button). 3. Click the tick button again to disable selection mode. GNOME builder now shows 'Other projects' title even when it is empty.
Yes, I am able to reproduce this bug. Working on a fix...
Created attachment 343978 [details] [review] Don't show Other Projects when it is empty The Other Projects label is shown even if it is empty when we go to selection state or gensis state and then cancel it to come back to the browse state. To fix this we have to call the function ide_greeter_perspective_apply_filter_all when the cancel button is clicked.
Review of attachment 343978 [details] [review]: fix the comments but LGTM ::: libide/greeter/ide-greeter-perspective.c @@ +758,3 @@ +static void +ide_greeter_perspective_cancel_or_genesis_cancel_clicked (IdeGreeterPerspective *self, + GtkButton *cancel_button) params alignment @@ +761,3 @@ +{ + g_assert (IDE_IS_GREETER_PERSPECTIVE (self)); + g_assert (GTK_IS_BUTTON (cancel_button)); empty line between assert and the rest of the code
Created attachment 343981 [details] [review] Don't show Other Projects when it is empty The Other Projects label is shown even if it is empty when we go to selection or genesis state and then cancel it to come back to the browse state. To fix this we have to call the function ide_greeter_perspective_apply_filter_all after changing the state to browse when the Cancel button is clicked.
Attachment 343981 [details] pushed as fb2b863 - Don't show Other Projects when it is empty