GNOME Bugzilla – Bug 771114
batch rename: '.' and '..' should be folder names when renaming folders
Last modified: 2017-08-18 12:52:00 UTC
when '.' and '..' are listed as file names when renaming folders, the conflict message says: ".." is an unallowed file name Instead, the conflict message can be: ".." is an unallowed name (just avoid the 'file')
Created attachment 340322 [details] [review] Batch rename: display message fixed I fixed the conflict message when you're trying to create a directory with '.' and '..' name, from "is an unallowed file name" in "is an unallowed name".
Review of attachment 340322 [details] [review]: Hey Mihai, Thanks for the patch!! The commit message has small issues, you have a guide for doing good commit messages in https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines. In this case: - The file name should be as how it is in the filesystem but whithouh the nautilus- prefix and withouth the file extension. So in this case, batch-rename-dialog. - Don't use "I" - Needs to explain why the change - Use the present and imperative form of verbs If you have any doubts feel free to ping me in IRC :)
Review of attachment 340322 [details] [review]: I would also change the string to something like “is not a valid name”. A bit less awkwardly worded.
Created attachment 357895 [details] [review] batch-rename-dialog: Use better wording Nautilus was using "unallowed" which sounds odd and also "file name" when in reality can also be folders.
I actually reworked it to use better wording in general. Attachment 357895 [details] pushed as 9db6240 - batch-rename-dialog: Use better wording