After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771109 - batch rename: crash if user types too fast
batch rename: crash if user types too fast
Status: RESOLVED DUPLICATE of bug 771129
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.21.x
Other Linux
: Normal critical
: 3.22
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-09 09:40 UTC by Mohammed Sadiq
Modified: 2016-09-16 07:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Backtrace (38.07 KB, text/plain)
2016-09-09 09:40 UTC, Mohammed Sadiq
Details

Description Mohammed Sadiq 2016-09-09 09:40:12 UTC
Created attachment 335168 [details]
Backtrace

If the user inserts text to replacement text very fast, Nautilus may crash.

How to reproduce:
1. Create several files:
   touch {0000..9999}.txt
2. Select any two files -> Rename -> "Find and Replace text"
3. type text as fast as possible. Nautilus may segfault here.

This doesn't happen always though. Before testing, killall Nautilus instances, and test in a freshly opened instance. This happens mostly when the deselected file list is too big.

Though the attached backtrace says "corrupted double-linked list," I get different reasons on different crashes.
Comment 1 Carlos Soriano 2016-09-13 21:31:54 UTC
I believe this is fixed since the last refactoring we did, which uses GTask and cancellables appropiately.
https://git.gnome.org/browse/nautilus/commit/?id=66693775d91eb8278bc7f9d0c5674cdccbc3dd0b
Comment 2 Mohammed Sadiq 2016-09-14 01:00:07 UTC
Still present in master.

Reopening.
Comment 3 Mohammed Sadiq 2016-09-14 01:45:30 UTC
In Nautilus files/folder search, If I type too fast, it seems like the search is delayed until the typing is complete (ie, when nautilus receives no more characters for certain time, probably some few milliseconds). But in batch renaming, the searching begins as soon as the first character is typed.

This may be a way for the fix, if not done already.

Thank you.
Comment 4 Carlos Soriano 2016-09-14 08:55:30 UTC
You mean in Search & Replace? I cannot manage to reproduce
Comment 5 Mohammed Sadiq 2016-09-14 15:18:24 UTC
I can also reproduce by keeping on pressing any single key on keyboard, or by copying some text, and paste by keeping on pressing C-v
Comment 6 Carlos Soriano 2016-09-16 07:38:36 UTC
same as 771129, we are freeing after free somewhere

*** This bug has been marked as a duplicate of bug 771129 ***