After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771104 - element: seek_simple() does not reset stop position
element: seek_simple() does not reset stop position
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.9.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-09 08:46 UTC by Sebastian Dröge (slomo)
Modified: 2016-09-30 07:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
element: Reset the stop position to NONE in seek_simple() (1.19 KB, patch)
2016-09-09 08:46 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-09-09 08:46:00 UTC 
When using seek_simple() in combination with other kinds of seeks, this becomes problematic. seek_simple() does not reset the stop position to GST_CLOCK_TIME_NONE but keeps whatever a previous seek did. So for example when doing a seek_simple() after a rate=-1 seek, we would usually get assertions that start>stop (and stop being the old stop from the rate=1 seek).

Attached patch fixes that but also slightly changes behaviour, shouldn't break anything that worked before though.
Comment 1 Sebastian Dröge (slomo) 2016-09-09 08:46:54 UTC 
Created attachment 335159 [details] [review]
element: Reset the stop position to NONE in seek_simple()

When using seek_simple() in combination with other kinds of seeks, this
becomes problematic. seek_simple() does not reset the stop position to
GST_CLOCK_TIME_NONE but keeps whatever a previous seek did. So for example
when doing a seek_simple() after a rate=-1 seek, we would usually get
assertions that start>stop (and stop being the old stop from the rate=1 seek).
Comment 2 Sebastian Dröge (slomo) 2016-09-10 08:00:50 UTC 
Attachment 335159 [details] pushed as 1b7ab25 - element: Reset the stop position to NONE in seek_simple()