GNOME Bugzilla – Bug 771082
Icon for go-down-symbolic has vanished
Last modified: 2017-09-26 16:02:41 UTC
Created attachment 335143 [details] Screenshot of gtk3-icon-browser It seems the icon "go-down-symbolic" has turned all blank.
Created attachment 335144 [details] screenshot confirmed at all sizes, and i'm using 3.21.91 in debian unstable fwiw
Seeing the same in openSUSE with 3.21.91 So confirmed from here too.
Created attachment 335158 [details] [review] symbolic: re-render go-down - go-home and user-home had the bounding rectangle name go-down, thus the export script picked one of the blank rects to crop. somebody is being sloppy with the metadata! boo boo
Attachment 335158 [details] pushed as cf64e98 - symbolic: re-render go-down
(In reply to Jakub Steiner from comment #3) > Created attachment 335158 [details] [review] [review] > symbolic: re-render go-down > > - go-home and user-home had the bounding rectangle name go-down, > thus the export script picked one of the blank rects to crop. > somebody is being sloppy with the metadata! boo boo Hmm. isn't there a way to automatically check if the generated icons are, say not blank ?
(In reply to Jakub Steiner from comment #4) > Attachment 335158 [details] pushed as cf64e98 - symbolic: re-render go-down Still seeing the same issue. Is src/symbolic/gnome-stencils.svg ( checkin ) relevant to this bug ?
(In reply to vrishab from comment #6) > Is src/symbolic/gnome-stencils.svg ( checkin ) relevant to this bug ? I think "Adwaita/scalable/actions/go-down-symbolic.svg" is missing in this checkin.
*** Bug 771409 has been marked as a duplicate of this bug. ***
*** Bug 771414 has been marked as a duplicate of this bug. ***
Built a fresh checkout and go-down-symbolic is still blank.
Created attachment 335951 [details] [review] symbolic: go-down-symbolic - user-home had a stray go-down label on a group that might cause render issues.
Not sure why, but gtk3-icon-browser still renders it blank, despite the exported icon rendering fine with eog.
Created attachment 335953 [details] invisible icon
(In reply to Jakub Steiner from comment #12) > Not sure why, but gtk3-icon-browser still renders it blank, despite the > exported icon rendering fine with eog. gtk3-icon-browser displays png entries ( not svg ), I guess. So, try after exporting to png and installing the icons in their respective locations.
There were issues with stray rectangles named go-down-symbolic which made me think it was all that was to it. But when I build adwaita-icon-theme I see these things -- /opt/gnome/bin/gtk-encode-symbolic-svg /home/jimmac/checkout/gnome/adwaita-icon-theme/Adwaita/scalable/$file $size -o /opt/gnome/_jhbuild/root-adwaita-icon-theme/opt/gnome/share/icons/Adwaita/$size/$context; \ done \ done Can't load file: Error writing Can't load file: Error writing Can't load file: Error writing Can't load file: Error writing Can't load file: Error writing Can't load file: Error writing I don't fully grok the png fallback for the svgs, but I bet that's where the issue lies.
All generated go-down-symbolic.symbolic.png sizes render fine as a black arrow in eog btw.
Latest git works fine. Relevant git commit: https://git.gnome.org/browse/adwaita-icon-theme/commit/?id=00e21c452e65a911b05195648b1212d12d76d576
Hi Jakub, wanted to mention a few things. 1. From reading the bug report, I must say that I don't fully understand, what is this bug all about. Things like "stray rectangles named go-down-symbolic" sound totally clueless to me. Is there a way to make sure, this problem can be avoided in the future ? 2. Build ( make ) should have failed when "Comment #15" is encountered. How did the build get past that ? 3. Do you think, having a sanity check script, which checks the svg and generated png images for filesize > 0 ( or something like that ), would be a good idea ? Maybe add the check to the build ( make ) script, so it would make your job easier next time.
can't reproduce with 00e21c452e65a911b05195648b1212d12d76d576, the go-down-symbolic shows up as expected in the icon browser and go-down-symbolic.svg is correct here.