GNOME Bugzilla – Bug 771070
batch rename: Don't fail silently on illegal metadata
Last modified: 2016-11-04 10:07:42 UTC
Created attachment 335132 [details] pdf file with title 'GNU/Linux' for test Currently no feedback is given if illegal characters are present in metadata. And the rename process silently fails. In this case ideally the user should be informed. A pdf file is attached with title "GNU/Linux" in case a file is required to test this. This file has to be added to tracker first (tracker index --file filename).
oh I didn't think about this... good catch too!
Created attachment 336796 [details] [review] batch-rename-dialog: identify conflict for illegal metadata chars If the metadata has the character "/" the conflict is not identified. To fix this, rather than looking at the entry text, the new names will be checked for the unallowed characters and names.
Review of attachment 336796 [details] [review]: Hmm I think it's very unfortunate because we display the error label just under the entry like what's expecting to do, and also we allow to set the metadata even if we can know it's not valid beforehand. So I wonder if instead what we should do is read the metadata for invalid characters and disable the button in the popover instead if that happens (and we will have to figure out how to display why is it not available, we can think different solutions to that for 3.24)
Created attachment 338639 [details] [review] batch-rename-dialog: disable metadata for illegal metadata chars If the metadata has the character "/" the metadata cannot be used. Rather than showing a conflict when this metadata is used, it should actually be disabled, because the user will never be able to rename the files using this metadata.
Review of attachment 338639 [details] [review]: I think for now is good enough, let's go with this, thanks!
Attachment 338639 [details] pushed as 57179d6 - batch-rename-dialog: disable metadata for illegal metadata chars