After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771063 - altTab: Don't mess up MRU order while cycling windows
altTab: Don't mess up MRU order while cycling windows
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-08 16:02 UTC by Florian Müllner
Modified: 2016-09-08 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
altTab: Don't mess up MRU order while cycling windows (4.86 KB, patch)
2016-09-08 16:02 UTC, Florian Müllner 		committed Details | Review
altTab: Add CyclerHighlight style (749 bytes, patch)
2016-09-08 16:03 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-09-08 16:02:50 UTC 
See patch.
Comment 1 Florian Müllner 2016-09-08 16:02:54 UTC 
Created attachment 335127 [details] [review]
altTab: Don't mess up MRU order while cycling windows

Commit bd6e7f14d17b reimplemented the cycle keybindings to
fix cycling between more than two windows, but the approach
of highlighting cycled windows by actually focusing them has
the drawback that cycling messes up the MRU order of windows.
To fix this, only change the window focus when the operation
finishes, and use a dedicated actor that draws a border around
a window clone for highlighting.
Comment 2 Florian Müllner 2016-09-08 16:03:30 UTC 
Created attachment 335128 [details] [review]
altTab: Add CyclerHighlight style

We need an indication while cycling through windows, so add a nice
big border.

Corresponding SASS patch.
Comment 3 Rui Matos 2016-09-08 18:22:08 UTC 
Review of attachment 335127 [details] [review]:

looks great
Comment 4 Florian Müllner 2016-09-08 19:30:56 UTC 
Comment on attachment 335128 [details] [review]
altTab: Add CyclerHighlight style

Attachment 335128 [details] pushed as b219008 - altTab: Add CyclerHighlight style
Comment 5 Florian Müllner 2016-09-08 19:33:24 UTC 
Attachment 335127 [details] pushed as 3171819 - altTab: Don't mess up MRU order while cycling windows