After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771026 - test-suite failures: pixbuf-composite segfaults
test-suite failures: pixbuf-composite segfaults
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-07 20:58 UTC by Michael Biebl
Modified: 2016-09-08 20:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make sure to NULL terminate the arguments passed to g_test_get_filename() (956 bytes, patch)
2016-09-08 16:55 UTC, Michael Biebl 		none Details | Review

Description Michael Biebl 2016-09-07 20:58:05 UTC 
Version: 2.35.4

On all architectures but amd64, the test suite fails on the debian buildds:
https://buildd.debian.org/status/package.php?p=gdk-pixbuf

The failing test is  pixbuf-composite. 

on i386
~~~~~~~
ERROR: pixbuf-composite
=======================

**
GLib:ERROR:/build/glib2.0-E8y2Xu/glib2.0-2.49.6/./glib/gtestutils.c:3361:g_test_build_filename_va: assertion failed (num_path_segments < G_N_ELEMENTS (pathv)): (16 < 16)
Aborted
# random seed: R02Sc22c9ad260066d3d905a7b2bba549525
1..2
# Start of pixbuf tests
ok 1 /pixbuf/composite1
PASS: pixbuf-composite 1 /pixbuf/composite1
# GLib:ERROR:/build/glib2.0-E8y2Xu/glib2.0-2.49.6/./glib/gtestutils.c:3361:g_test_build_filename_va: assertion failed (num_path_segments < G_N_ELEMENTS (pathv)): (16 < 16)
ERROR: pixbuf-composite - too few tests run (expected 2, got 1)
ERROR: pixbuf-composite - exited with status 134 (terminated by signal 6?)

on other architectures the error message is either
ERROR: pixbuf-composite
=======================

Segmentation fault
# random seed: R02S293522ca89fc2a50484a30df9f6d1cf1
1..2
# Start of pixbuf tests
ok 1 /pixbuf/composite1
PASS: pixbuf-composite 1 /pixbuf/composite1
ERROR: pixbuf-composite - too few tests run (expected 2, got 1)
ERROR: pixbuf-composite - exited with status 139 (terminated by signal 11?)

or 

ERROR: pixbuf-composite
=======================

Bus error
# random seed: R02S3e863db864e9dcb08b52712a225e242b
1..2
# Start of pixbuf tests
ok 1 /pixbuf/composite1
PASS: pixbuf-composite 1 /pixbuf/composite1
ERROR: pixbuf-composite - too few tests run (expected 2, got 1)
ERROR: pixbuf-composite - exited with status 138 (terminated by signal 10?)
Comment 1 Michael Biebl 2016-09-08 16:55:50 UTC 
Created attachment 335131 [details] [review]
Make sure to NULL terminate the arguments passed to  g_test_get_filename()
Comment 2 Michael Biebl 2016-09-08 20:50:11 UTC 
Since the fix is rather obvious, I just went ahead and pushed it as commit 89a7a851042f2706e8e7e27da6e4bfb08717430f