After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771010 - man 7 gvfs is missing gvfs-goa-volume-monitor, gvfs-gphoto2-volume-monitor and gvfs-mtp-volume-monitor
man 7 gvfs is missing gvfs-goa-volume-monitor, gvfs-gphoto2-volume-monitor an...
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-07 14:19 UTC by Christian Stadelmann
Modified: 2016-10-03 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for man page (1.53 KB, patch)
2016-09-07 14:22 UTC, Christian Stadelmann
reviewed Details | Review
man: Add missing backends (1.64 KB, patch)
2016-09-08 13:24 UTC, Ondrej Holy
none Details | Review
man: Various fixes (1.43 KB, patch)
2016-09-08 13:25 UTC, Ondrej Holy
none Details | Review
man: Add missing volume monitors (1.51 KB, patch)
2016-10-03 14:31 UTC, Ondrej Holy
committed Details | Review
man: Add missing backends (1.63 KB, patch)
2016-10-03 14:31 UTC, Ondrej Holy
committed Details | Review
man: Various fixes (1.67 KB, patch)
2016-10-03 14:31 UTC, Ondrej Holy
committed Details | Review

Description Christian Stadelmann 2016-09-07 14:19:37 UTC
On a fully updated Fedora 24 (Gnome 3.20, gvfs 1.28.3), the man page for gvfs(7) is missing these volume monitor daemons which are running by default:

gvfs-goa-volume-monitor
gvfs-gphoto2-volume-monitor
gvfs-mtp-volume-monitor

This issue is also present in git master.

Some mount backends might be missing, I haven't checked that.
Comment 1 Christian Stadelmann 2016-09-07 14:22:09 UTC
Created attachment 334992 [details] [review]
Patch for man page

I've created a patch.
Comment 2 Ondrej Holy 2016-09-08 13:23:48 UTC
Review of attachment 334992 [details] [review]:

Thanks! I would just write something like:

::: man/gvfs.xml
@@ +62,3 @@
                         <listitem><para>gvfs-afc-volume-monitor - a volume monitor for Apple iPhone/iPod Touch devices</para></listitem>
+                        <listitem><para>gvfs-goa-volume-monitor - a volume monitor for GNOME Online Accounts</para></listitem>
+                        <listitem><para>gvfs-gphoto2-volume-monitor - a volume monitor for cameras through gphoto2</para></listitem>

a volume monitor for PTP devices
(because it is not just for cameras only)

@@ +63,3 @@
+                        <listitem><para>gvfs-goa-volume-monitor - a volume monitor for GNOME Online Accounts</para></listitem>
+                        <listitem><para>gvfs-gphoto2-volume-monitor - a volume monitor for cameras through gphoto2</para></listitem>
+                        <listitem><para>gvfs-mtp-volume-monitor - a volume monitor for portable media players through Media Transfer Protocol </para></listitem>

similar here:
a volume monitor for MTP devices
Comment 3 Ondrej Holy 2016-09-08 13:23:57 UTC
Review of attachment 334992 [details] [review]:

Thanks! I would just write something like:

::: man/gvfs.xml
@@ +62,3 @@
                         <listitem><para>gvfs-afc-volume-monitor - a volume monitor for Apple iPhone/iPod Touch devices</para></listitem>
+                        <listitem><para>gvfs-goa-volume-monitor - a volume monitor for GNOME Online Accounts</para></listitem>
+                        <listitem><para>gvfs-gphoto2-volume-monitor - a volume monitor for cameras through gphoto2</para></listitem>

a volume monitor for PTP devices
(because it is not just for cameras only)

@@ +63,3 @@
+                        <listitem><para>gvfs-goa-volume-monitor - a volume monitor for GNOME Online Accounts</para></listitem>
+                        <listitem><para>gvfs-gphoto2-volume-monitor - a volume monitor for cameras through gphoto2</para></listitem>
+                        <listitem><para>gvfs-mtp-volume-monitor - a volume monitor for portable media players through Media Transfer Protocol </para></listitem>

similar here:
a volume monitor for MTP devices
Comment 4 Ondrej Holy 2016-09-08 13:24:53 UTC
Created attachment 335114 [details] [review]
man: Add missing backends
Comment 5 Ondrej Holy 2016-09-08 13:25:20 UTC
Created attachment 335115 [details] [review]
man: Various fixes
Comment 6 Christian Stadelmann 2016-09-08 13:54:47 UTC
(In reply to Ondrej Holy from comment #2)
> Review of attachment 334992 [details] [review] [review]:
> 
> Thanks! I would just write something like:
> 
> ::: man/gvfs.xml
> @@ +62,3 @@
>                          <listitem><para>gvfs-afc-volume-monitor - a volume
> monitor for Apple iPhone/iPod Touch devices</para></listitem>
> +                        <listitem><para>gvfs-goa-volume-monitor - a volume
> monitor for GNOME Online Accounts</para></listitem>
> +                        <listitem><para>gvfs-gphoto2-volume-monitor - a
> volume monitor for cameras through gphoto2</para></listitem>
> 
> a volume monitor for PTP devices
> (because it is not just for cameras only)
> 
> @@ +63,3 @@
> +                        <listitem><para>gvfs-goa-volume-monitor - a volume
> monitor for GNOME Online Accounts</para></listitem>
> +                        <listitem><para>gvfs-gphoto2-volume-monitor - a
> volume monitor for cameras through gphoto2</para></listitem>
> +                        <listitem><para>gvfs-mtp-volume-monitor - a volume
> monitor for portable media players through Media Transfer Protocol
> </para></listitem>
> 
> similar here:
> a volume monitor for MTP devices

That's ok for me too, push yours instead as you wish. I just wanted to have them listed because they were missing.
Comment 7 Ondrej Holy 2016-09-08 14:11:57 UTC
Thanks, I will push it after freeze.
Comment 8 Ondrej Holy 2016-10-03 14:31:32 UTC
Created attachment 336819 [details] [review]
man: Add missing volume monitors

man 7 gvfs is missing some volume monitors, which are added by this
patch.

The patch was modified by Ondrej Holy <oholy@redhat.com>.
Comment 9 Ondrej Holy 2016-10-03 14:31:36 UTC
Created attachment 336820 [details] [review]
man: Add missing backends

Add missing backends in man page.
Comment 10 Ondrej Holy 2016-10-03 14:31:41 UTC
Created attachment 336821 [details] [review]
man: Various fixes
Comment 11 Ondrej Holy 2016-10-03 14:33:55 UTC
Attachment 336819 [details] pushed as dc2d436 - man: Add missing volume monitors
Attachment 336820 [details] pushed as 0df7830 - man: Add missing backends
Attachment 336821 [details] pushed as 19a85c3 - man: Various fixes