After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770994 - wayland/pointer-constraints: Send wl_pointer.frame when locked
wayland/pointer-constraints: Send wl_pointer.frame when locked
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-07 08:32 UTC by Jonas Ådahl
Modified: 2016-09-09 03:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland/pointer-constraints: Send wl_pointer.frame when locked (2.20 KB, patch)
2016-09-07 08:32 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2016-09-07 08:32:51 UTC 
We didn't send wl_pointer.frame when we should. The attached patch fixes that.
Comment 1 Jonas Ådahl 2016-09-07 08:32:54 UTC 
Created attachment 334965 [details] [review]
wayland/pointer-constraints: Send wl_pointer.frame when locked

We were not sending wl_pointer.frame after
wp_relative_pointer.relative_motion. Fix that.
Comment 2 Rui Matos 2016-09-07 13:47:55 UTC 
Review of attachment 334965 [details] [review]:

I suppose you don't want to put the broadcast_frame() call in meta_wayland_pointer_send_relative_motion() to avoid having two frame events in a row from meta_wayland_pointer_send_motion() ?

Anyway, there are no other callers, so looks good
Comment 3 Jonas Ådahl 2016-09-07 13:49:18 UTC 
(In reply to Rui Matos from comment #2)
> Review of attachment 334965 [details] [review] [review]:
> 
> I suppose you don't want to put the broadcast_frame() call in
> meta_wayland_pointer_send_relative_motion() to avoid having two frame events
> in a row from meta_wayland_pointer_send_motion() ?

Exactly.

> 
> Anyway, there are no other callers, so looks good

Thanks!
Comment 4 Jonas Ådahl 2016-09-09 03:11:08 UTC 
Attachment 334965 [details] pushed as 0c53677 - wayland/pointer-constraints: Send wl_pointer.frame when locked