GNOME Bugzilla – Bug 770974
batch rename says "Files" when renaming directories
Last modified: 2016-09-08 19:24:12 UTC
When several directories are selected for renaming, the batch rename dialog title says "Rename n Files". It should be "Rename n Folders".
Created attachment 335027 [details] [review] batch-rename-dialog: Update batch rename dialog title If all renamed files are folders, then the title will be: "Rename %d Folders"
Review of attachment 335027 [details] [review]: LGTM thanks! Nitpick, commit message title is not clear, doesn't really explain what "update title" is supposed to do. How about "batch-rename-dialog: difference "files" and "folders in the title Also we need to ask for a string freeze exception though. Will you or should I?
(In reply to Carlos Soriano from comment #2) > Review of attachment 335027 [details] [review] [review]: > > LGTM thanks! > > Nitpick, commit message title is not clear, doesn't really explain what > "update title" is supposed to do. How about "batch-rename-dialog: difference > "files" and "folders in the title > > Also we need to ask for a string freeze exception though. Will you or should > I? I sent the mail for the string freeze exception.
Created attachment 335082 [details] [review] batch-rename-dialog: differentiate "files" and "folders" in the title If all renamed files are folders, then the title will be: "Rename %d Folders"
Review of attachment 335082 [details] [review]: Thanks for sending the mail! I believe you are now used to all the "paperwork" of what a release involves in big projects like GNOME. Patch looks good now, wait until getting the string freeze exception for committing.
Comment on attachment 335027 [details] [review] batch-rename-dialog: Update batch rename dialog title Remember to obsolete old patches when changing the commit message. They don't get obsoleted automatically in that case (there is no way to automatically know it's the same patch)
Attachment 335082 [details] pushed as 7823e5e - batch-rename-dialog: differentiate "files" and "folders" in the title