After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770974 - batch rename says "Files" when renaming directories
batch rename says "Files" when renaming directories
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.21.x
Other Linux
: Normal normal
: 3.22
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-06 21:26 UTC by Mohammed Sadiq
Modified: 2016-09-08 19:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
batch-rename-dialog: Update batch rename dialog title (2.29 KB, patch)
2016-09-07 20:44 UTC, Alexandru Pandelea
accepted-commit_after_freeze Details | Review
batch-rename-dialog: differentiate "files" and "folders" in the title (2.31 KB, patch)
2016-09-08 10:40 UTC, Alexandru Pandelea
committed Details | Review

Description Mohammed Sadiq 2016-09-06 21:26:12 UTC
When several directories are selected for renaming, the batch rename dialog title says "Rename n Files". It should be "Rename n Folders".
Comment 1 Alexandru Pandelea 2016-09-07 20:44:51 UTC
Created attachment 335027 [details] [review]
batch-rename-dialog: Update batch rename dialog title

If all renamed files are folders, then the title will be:
"Rename %d Folders"
Comment 2 Carlos Soriano 2016-09-08 09:17:18 UTC
Review of attachment 335027 [details] [review]:

LGTM thanks!

Nitpick, commit message title is not clear, doesn't really explain what "update title" is supposed to do. How about "batch-rename-dialog: difference "files" and "folders in the title

Also we need to ask for a string freeze exception though. Will you or should I?
Comment 3 Alexandru Pandelea 2016-09-08 10:40:04 UTC
(In reply to Carlos Soriano from comment #2)
> Review of attachment 335027 [details] [review] [review]:
> 
> LGTM thanks!
> 
> Nitpick, commit message title is not clear, doesn't really explain what
> "update title" is supposed to do. How about "batch-rename-dialog: difference
> "files" and "folders in the title
> 
> Also we need to ask for a string freeze exception though. Will you or should
> I?

I sent the mail for the string freeze exception.
Comment 4 Alexandru Pandelea 2016-09-08 10:40:32 UTC
Created attachment 335082 [details] [review]
batch-rename-dialog: differentiate "files" and "folders" in the title

If all renamed files are folders, then the title will be:
"Rename %d Folders"
Comment 5 Carlos Soriano 2016-09-08 16:35:29 UTC
Review of attachment 335082 [details] [review]:

Thanks for sending the mail! I believe you are now used to all the "paperwork" of what a release involves in big projects like GNOME.

Patch looks good now, wait until getting the string freeze exception for committing.
Comment 6 Carlos Soriano 2016-09-08 16:36:29 UTC
Comment on attachment 335027 [details] [review]
batch-rename-dialog: Update batch rename dialog title

Remember to obsolete old patches when changing the commit message. They don't get obsoleted automatically in that case (there is no way to automatically know it's the same patch)
Comment 7 Alexandru Pandelea 2016-09-08 19:24:08 UTC
Attachment 335082 [details] pushed as 7823e5e - batch-rename-dialog: differentiate "files" and "folders" in the title