After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770959 - Add gperf check in configure.ac
Add gperf check in configure.ac
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: lua
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-06 17:00 UTC by Bastien Nocera
Modified: 2016-11-28 06:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Add gperf check for lua-factory source (1.68 KB, patch)
2016-11-27 00:19 UTC, gnome.vrb
committed Details | Review

Description Bastien Nocera 2016-09-06 17:00:09 UTC
Otherwise empty .c files will be created and problems ensue.
Comment 1 gnome.vrb 2016-11-26 22:09:47 UTC
grilo-plugins compilation fails as below:

make[4]: Entering directory '/local/packages/source/git/gnome/grilo-plugins/src/lua-factory'
  CC       libgrlluafactory_la-grl-lua-factory.lo
  CC       libgrlluafactory_la-grl-lua-library.lo
  CC       libgrlluafactory_la-grl-lua-library-operations.lo
  GEN      luafactoryresources.h
  GEN      luafactoryresources.c
  CC       libgrlluafactory_la-luafactoryresources.lo
  GEN      lua-library/htmlentity.c
/bin/bash: gperf: command not found
Makefile:1127: recipe for target 'lua-library/htmlentity.c' failed
make[4]: *** [lua-library/htmlentity.c] Error 127

----

Succeeds after installing gperf ( apt-get install gperf )

make[4]: Entering directory '/local/packages/source/git/gnome/grilo-plugins/src/lua-factory'
  CC       lua-library/libgrlluafactory_la-htmlentity.lo
  CC       lua-library/libgrlluafactory_la-lua-json.lo
  CC       lua-library/libgrlluafactory_la-lua-xml.lo
  CCLD     libgrlluafactory.la
make[4]: Leaving directory '/local/packages/source/git/gnome/grilo-plugins/src/lua-factory'
Comment 2 gnome.vrb 2016-11-27 00:19:57 UTC
Created attachment 340822 [details] [review]
build: Add gperf check for lua-factory source
Comment 3 gnome.vrb 2016-11-27 00:24:43 UTC
The patch builds grilo-plugins without building lua-factory, as below:

Plugins
	bookmarks           : yes
	chromaprint         : yes
	dleyna              : yes
	dmap                : yes
	filesystem          : yes
	flickr              : yes
	freebox             : yes
	gravatar            : yes
	jamendo             : yes
	localmetadata       : yes
	lua_factory         : no
...

But, I'm not sure what is expected here. To force the distribution maintainers to add gperf to grilo-plugins-0.3 / libgrilo-0.3-dev package depends, the patch needs to be changed.
Comment 4 Bastien Nocera 2016-11-28 06:42:22 UTC
Attachment 340822 [details] pushed as 46eb246 - build: Add gperf check for lua-factory source