After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770955 - [regression] typing group is missing 3 shortcuts
[regression] typing group is missing 3 shortcuts
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-09-06 15:15 UTC by Alberts Muktupāvels
Modified: 2016-09-10 19:11 UTC
See Also:
GNOME target: 3.22
GNOME version: ---

Attachments
xkb: XKB options are not in the 3.22 Keyboard panel (1.03 KB, patch)
2016-09-07 14:16 UTC, Bastien Nocera 		committed Details | Review
keyboard: Simplify keyboard option object creation (2.53 KB, patch)
2016-09-07 14:33 UTC, Bastien Nocera 		none Details | Review
keyboard: Add "value-description" property to CcKeyboardOption (2.71 KB, patch)
2016-09-07 14:33 UTC, Bastien Nocera 		none Details | Review
keyboard: Load CcKeyboardOptions (4.61 KB, patch)
2016-09-07 14:33 UTC, Bastien Nocera 		none Details | Review
keyboard: Show CcKeyboardOptions in the list (8.39 KB, patch)
2016-09-07 14:33 UTC, Bastien Nocera 		none Details | Review

Description Alberts Muktupāvels 2016-09-06 15:15:48 UTC 
Typing group is missing 3 shortcuts. Regression introduced in c4e1ca2ee0a70fd70dec288f9aa157f140386a2b commit.

Removed part:
if (g_str_equal (id, "Typing"))
  fill_xkb_options_shortcuts (shortcut_model);
Comment 1 Bastien Nocera 2016-09-07 14:16:48 UTC 
Created attachment 334991 [details] [review]
xkb: XKB options are not in the 3.22 Keyboard panel
Comment 2 Bastien Nocera 2016-09-07 14:20:18 UTC 
See bug 771009 for the post-3.22 plan.
Comment 3 Rui Matos 2016-09-07 14:31:42 UTC 
Review of attachment 334991 [details] [review]:

sure
Comment 4 Bastien Nocera 2016-09-07 14:33:21 UTC 
Created attachment 334995 [details] [review]
keyboard: Simplify keyboard option object creation
Comment 5 Bastien Nocera 2016-09-07 14:33:27 UTC 
Created attachment 334996 [details] [review]
keyboard: Add "value-description" property to CcKeyboardOption
Comment 6 Bastien Nocera 2016-09-07 14:33:33 UTC 
Created attachment 334997 [details] [review]
keyboard: Load CcKeyboardOptions

And emit the "option-added" signal when we do.
Comment 7 Bastien Nocera 2016-09-07 14:33:39 UTC 
Created attachment 334998 [details] [review]
keyboard: Show CcKeyboardOptions in the list
Comment 8 Bastien Nocera 2016-09-07 14:34:14 UTC 
Comment on attachment 334995 [details] [review]
keyboard: Simplify keyboard option object creation

Wrong bug.
Comment 9 Bastien Nocera 2016-09-07 14:36:00 UTC 
Attachment 334991 [details] pushed as e9db2f8 - xkb: XKB options are not in the 3.22 Keyboard panel
Comment 10 Andreas Kloeckner 2016-09-10 19:11:03 UTC 
Thanks for noticing this. That said, from a user's perspective, what's a flaming disaster is that this setting keeps switching locations...