GNOME Bugzilla – Bug 770951
qtdemux: Crash with no cenc auxiliary offset available
Last modified: 2016-09-30 07:04:51 UTC
Created attachment 334908 [details] [review] 1/1 gst-plugins-good patch This bug is a side effect of bug 770107 when running http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html?enablewebm=false&command=run&test_type=encryptedmedia-test&tests=16,17 . As we don't have a key at the moment this code is run, crypto_info is null and we don't have any cenc aux offset, which causes a crash some lines later when retrieving the index.
commit 92075e0256584b3ce22ff00d4c7a835ab296ddb0 Author: Xabier Rodriguez Calvar <calvaris@igalia.com> Date: Tue Sep 6 09:49:39 2016 +0200 qtdemux: Fix crash with no cenc aux offset https://bugzilla.gnome.org/show_bug.cgi?id=770951
I hope someone checked the use-case of #762516 still works :)
(In reply to Philippe Normand from comment #2) > I hope someone checked the use-case of #762516 still works :) This still works but I think it might be causing issues, before release 1.9.3, this should be reverted.
(In reply to Xabier Rodríguez Calvar from comment #3) > This still works but I think it might be causing issues, before release > 1.9.3, this should be reverted. Maybe no rush so far, but let's keep this in mind.
What's the problem?
(In reply to Sebastian Dröge (slomo) from comment #5) > What's the problem? One of our customers says that something is crashing with that patch and it doesn't without it. I couldn't investigate it so I cannot provide more info atm.
Created attachment 335204 [details] [review] 2/2 gst-plugins-good patch This patch applies on top of the other one so that we don't have to revert it. I have no deep knowledge about parsing these formats but from what I see the code after this guarded if makes no sense and it will crash if info->crypt_info is null, regardless of the offset. Please correct me if I am wrong. The tests I made run successfully now.
Makes sense, the offset should indeed not matter and an offset of 0 also seems to be valid even. commit 415ae458d27ae4be5cf2dffaef9b496bef3942b8 Author: Xabier Rodriguez Calvar <calvaris@igalia.com> Date: Fri Sep 9 14:02:25 2016 +0200 qtdemux: offset is irrelevant when no crypto info Cause later it will try to use the crypto info array to get an index and attach on of the positions as buffer's crypto info. https://bugzilla.gnome.org/show_bug.cgi?id=770951