GNOME Bugzilla – Bug 770918
Fix updating remotes' appstream
Last modified: 2018-01-24 17:13:38 UTC
Currently if there are multiple remotes to fetch the appstream data from, and doing so fails for one of them, then the remaining remotes will never be updated. This leads to cases where, e.g. having one remote with a broken gpg key (or with a user without permissions to pull from an untrusted source) may prevent getting updates from other valid remotes. Maybe the solution I provide is an easy one but in any case, one failing remote should never prevent refreshing the appstream data of other remotes so I think the operation should continue and a warning should be printed when that situation happens.
Created attachment 334860 [details] [review] Continue refresh even if it's not possible to update a remote's appstream Otherwise it leads to cases where, e.g. having one remote with a broken gpg key (or with a user without permissions to pull from an untrusted source) may prevent updating other valid remotes. These changes do not quit the refresh operation when updating one remote fails and promote a debug message to a warning so it is more visible.
Whilst I think you're right in the bug description, I still think we need to show these warnings to the user (perhaps in a GtkInfoBox) rather than just hide it on the console. I'll have a play with this idea today.
I've pushed up some ideas to wip/hughsie/GsPluginEvent
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-software/issues/86.