After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770903 - Use IANA registered mime-type for comics
Use IANA registered mime-type for comics
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: backends
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-05 15:26 UTC by Bastien Nocera
Modified: 2016-09-12 17:28 UTC
See Also:
GNOME target: 3.22
GNOME version: ---

Attachments
comics: Add application/vnd.comicbook+zip support (1.36 KB, patch)
2016-09-12 15:58 UTC, Bastien Nocera 		committed Details | Review
comics: Fix mime-type comparisons (2.73 KB, patch)
2016-09-12 15:58 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2016-09-05 15:26:06 UTC 
It's application/vnd.comicbook+zip, application/x-cbz is an alias in the newest release of shared-mime-info.
Comment 1 Bastien Nocera 2016-09-12 15:58:02 UTC 
Created attachment 335373 [details] [review]
comics: Add application/vnd.comicbook+zip support

application/vnd.comicbook+zip is the new mime-type for ".cbz" files.
Other mime-types are still available as aliases of that type.
Comment 2 Bastien Nocera 2016-09-12 15:58:09 UTC 
Created attachment 335374 [details] [review]
comics: Fix mime-type comparisons

The comics backend was using string equality to match mime-types. This
doesn't work when the mime-type has changed, and the old name is now
simply an alias. Use g_content_type_is_a() instead.
Comment 3 Carlos Garcia Campos 2016-09-12 16:11:52 UTC 
Comment on attachment 335374 [details] [review]
comics: Fix mime-type comparisons

Much better, thanks!
Comment 4 Bastien Nocera 2016-09-12 17:28:47 UTC 
Attachment 335373 [details] pushed as 71b1323 - comics: Add application/vnd.comicbook+zip support
Attachment 335374 [details] pushed as 364b340 - comics: Fix mime-type comparisons