After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770878 - less button padding than other apps
less button padding than other apps
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-09-05 09:46 UTC by Andreas Nilsson
Modified: 2016-09-06 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (1.33 MB, image/png)
2016-09-05 09:46 UTC, Andreas Nilsson
Details
screenshot with stackswitcher applied (103.42 KB, image/png)
2016-09-06 09:29 UTC, Andreas Nilsson
Details

Description Andreas Nilsson 2016-09-05 09:46:21 UTC
Created attachment 334777 [details]
screenshot

Compared to other gnome apps, there is not a lot of padding in the header bar buttons of GNOME Software.
Comment 1 Richard Hughes 2016-09-06 08:53:13 UTC
Are there any guidelines in the HIG? I agree we should fix this, but it would be good to have a spec so all apps are the same, even if it's a bit fluffy and wordy.
Comment 2 Andreas Nilsson 2016-09-06 09:11:28 UTC
Only thing I could find was a wireframe.
https://raw.githubusercontent.com/gnome-design-team/gnome-mockups-software/master/wireframes/search-results.png
Comment 3 Andreas Nilsson 2016-09-06 09:22:35 UTC
I think it might be a thing with "box" vs "stackswitcher", because when I switched to that, the buttons got a lot more padding all of a sudden.
https://developer.gnome.org/gtk3/stable/GtkStackSwitcher.html
Comment 4 Andreas Nilsson 2016-09-06 09:29:35 UTC
Created attachment 334885 [details]
screenshot with stackswitcher applied

Making the box into a stackswitcher with the inspector made things extra wide though, so not sure if something more is needed.
Comment 5 Richard Hughes 2016-09-06 13:59:16 UTC
commit 9b51b6396883ddac189e07a3f997324c78f0da10
Author: Richard Hughes <richard@hughsie.com>
Date:   Tue Sep 6 14:58:30 2016 +0100

    Use the same padding as a GtkStackSwitcher
    
    We can't actually use GtkStackSwitcher as we use custom content in buttons
    (for instance, the updates counter label) and because we have other hidden
    pages in the GtkStack that can't be hidden.
    
    Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=770878
Comment 6 Andreas Nilsson 2016-09-06 16:24:56 UTC
Looks much better now. Thanks for the quick fix!