After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770781 - No covers for PSX games
No covers for PSX games
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-03 10:54 UTC by Mathieu Bridon
Modified: 2016-09-06 20:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
playstation: Get covers from Grilo if no local is found (1.28 KB, patch)
2016-09-03 12:44 UTC, Adrien Plazas
committed Details | Review

Description Mathieu Bridon 2016-09-03 10:54:16 UTC
Games doesn't show the covers for any of my PSX games.

It shows them correctly for the games for other consoles.
Comment 1 Adrien Plazas 2016-09-03 12:44:36 UTC
Created attachment 334711 [details] [review]
playstation: Get covers from Grilo if no local is found
Comment 2 Mathieu Bridon 2016-09-03 13:47:22 UTC
With this patch applied I get covers for PSX games!

One problem though: I have a game, "Final Fantasy IX" which got the cover from "Final Fantasy Anthology".
Comment 3 Adrien Plazas 2016-09-03 13:52:20 UTC
This problem comes from the website for sending bad results and from the Grilo plugin for not curating these bad results.
Comment 4 Adrien Plazas 2016-09-03 14:01:24 UTC
Attachment 334711 [details] pushed as b1a2b9f - playstation: Get covers from Grilo if no local is found
Comment 5 Bastien Nocera 2016-09-05 10:17:16 UTC
(In reply to Adrien Plazas from comment #3)
> This problem comes from the website for sending bad results and from the
> Grilo plugin for not curating these bad results.

There won't be curation in a plugin, just how can we do curation? Maybe you want to try and file a bug with a test case so it gets fixed if possible.
Comment 6 Mathieu Bridon 2016-09-06 17:14:39 UTC
(In reply to Bastien Nocera from comment #5)
> (In reply to Adrien Plazas from comment #3)
> > This problem comes from the website for sending bad results and from the
> > Grilo plugin for not curating these bad results.
> 
> There won't be curation in a plugin, just how can we do curation? Maybe you
> want to try and file a bug with a test case so it gets fixed if possible.

Just to close this completely: the game just doesn't exist in thegamesdb, that's why I don't get the right cover.
Comment 7 Adrien Plazas 2016-09-06 20:18:14 UTC
(In reply to Bastien Nocera from comment #5)
> (In reply to Adrien Plazas from comment #3)
> > This problem comes from the website for sending bad results and from the
> > Grilo plugin for not curating these bad results.
> 
> There won't be curation in a plugin, just how can we do curation? Maybe you
> want to try and file a bug with a test case so it gets fixed if possible.

Why not just a little bit? I remember a case where the media's title was "Sonic the Hedgehog" and thegamesdb returned the correct game in its list of results but not as the first one, but the Grilo plugin just picked the first one without checking that the result was what we expected, which is obviously wrong. Whether it is on the Grilo plugin or on the website itself we should do something.