After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770778 - file operation popover height too small after last gtk+ gtkscrolledwindow change.
file operation popover height too small after last gtk+ gtkscrolledwindow cha...
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 770943 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-09-03 05:58 UTC by Hussam Al-Tayeb
Modified: 2016-09-08 19:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
nautilus small popover. (33.83 KB, image/png)
2016-09-03 05:58 UTC, Hussam Al-Tayeb 		  Details
nautilus-toolbar.ui: propagate operations popover children height (1.08 KB, patch)
2016-09-03 13:42 UTC, Ernestas Kulik 		committed Details | Review

Description Hussam Al-Tayeb 2016-09-03 05:58:49 UTC 
Created attachment 334702 [details]
nautilus small popover.

After https://git.gnome.org/browse/gtk+/commit/?id=0984d1622d022bf67207f985f7842b6299818e20
nautilus file operation popover is too small.
Notice the attached screenshot.
Comment 1 Hussam Al-Tayeb 2016-09-03 06:03:25 UTC 
Those warnings appear in the terminal when the popover shows.

(nautilus:16393): Gtk-WARNING **: GtkMenuButton 0x1ff2500 is drawn without a current allocation. This should not happen.

(nautilus:16393): Gtk-WARNING **: GtkDrawingArea 0x1ff60f0 is drawn without a current allocation. This should not happen.

(nautilus:16393): Gtk-WARNING **: GtkMenuButton 0x1ff2500 is drawn without a current allocation. This should not happen.

(nautilus:16393): Gtk-WARNING **: GtkDrawingArea 0x1ff60f0 is drawn without a current allocation. This should not happen.

(nautilus:16393): Gtk-WARNING **: GtkMenuButton 0x1ff2500 is drawn without a current allocation. This should not happen.

(nautilus:16393): Gtk-WARNING **: GtkDrawingArea 0x1ff60f0 is drawn without a current allocation. This should not happen.
Comment 2 Hussam Al-Tayeb 2016-09-03 06:06:24 UTC 
I asked about the warnings on irc.

baedert: it's very obious on wayland but also reproducible on X but harder.
Comment 3 Hussam Al-Tayeb 2016-09-03 11:26:44 UTC 
Just to remove confusion, I am using Xorg with Nvidia drivers.
Comment 4 Ernestas Kulik 2016-09-03 13:42:28 UTC 
Created attachment 334712 [details] [review]
nautilus-toolbar.ui: propagate operations popover children height

Without propagating the natural height of the children of the operations
popover, it does not grow vertically.
Comment 5 Ernestas Kulik 2016-09-03 13:42:50 UTC 
I suppose we should be doing this now?
Comment 6 Ernestas Kulik 2016-09-06 11:38:52 UTC 
*** Bug 770943 has been marked as a duplicate of this bug. ***
Comment 7 Carlos Soriano 2016-09-07 08:03:56 UTC 
Hey Ernestas, I couldn't catch you in IRC. I'm delaying the review since I still see some strange behaviours in the gtk3-widget-factory regarding this property, so I'm not sure how stable all the scrolled window status is.
Comment 8 Carlos Soriano 2016-09-08 18:58:04 UTC 
Review of attachment 334712 [details] [review]:

Further investigation with gtk+ master points that this is correct. Thanks Ernestas!
Comment 9 Ernestas Kulik 2016-09-08 18:59:57 UTC 
Attachment 334712 [details] pushed as 2f878b7 - nautilus-toolbar.ui: propagate operations popover children height