After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770723 - Add precision for Sampler3D
Add precision for Sampler3D
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: GLES
1.22.x
Other All
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-09-02 01:53 UTC by Lionel Landwerlin
Modified: 2016-09-02 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add precision for Sampler3D (2.32 KB, patch)
2016-09-02 01:53 UTC, Lionel Landwerlin
committed Details | Review

Description Lionel Landwerlin 2016-09-02 01:53:02 UTC
GLES spec 3.0 - 4.5.4 Default Precision Qualifiers

defines the default precisions as follow for the vertex shaders :

precision highp float;
precision highp int;
precision lowp sampler2D;
precision lowp samplerCube;

and for the fragment shaders :

precision mediump int;
precision lowp sampler2D;
precision lowp samplerCube;

Therefore we need to set the Sampler3D precision in both vertex & fragment
shaders.

This also reverts :

"conform: Disable 3D textures on GLES"
commit ea34b9d7b9ade78b04d4056feb0a13fce6f7c953.
Comment 1 Lionel Landwerlin 2016-09-02 01:53:07 UTC
Created attachment 334614 [details] [review]
Add precision for Sampler3D
Comment 2 Lionel Landwerlin 2016-09-02 01:54:59 UTC
Emmanuele, I figured you could be interested :)
Comment 3 Emmanuele Bassi (:ebassi) 2016-09-02 11:04:18 UTC
Review of attachment 334614 [details] [review]:

Looks good to me.
Comment 4 Lionel Landwerlin 2016-09-02 11:10:27 UTC
Review of attachment 334614 [details] [review]:

Pushed to cogl-1.22 branch.