After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770683 - Not start code and slice_data_offset for H.264(AVC) VASliceDataBufferType type data
Not start code and slice_data_offset for H.264(AVC) VASliceDataBufferType typ...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: git master
Assigned To: Randy Li (ayaka)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-31 22:20 UTC by Randy Li (ayaka)
Modified: 2018-11-03 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Randy Li (ayaka) 2016-08-31 22:20:25 UTC
The Intel i915 VA-API doesn't require the start code for H.264(AVS) but the HEVC does, it would use the slice_data_offset to omit the start code prefix(0x000001). But some hardware video process do require the start code for AVS. The known device are those ARM chips from rockchips.

It would be not strip the start code for AVS to work in all the devices.
Comment 1 sreerenj 2016-09-01 08:37:28 UTC
(In reply to ayaka from comment #0)
> The Intel i915 VA-API doesn't require the start code for H.264(AVS) but the
> HEVC does, it would use the slice_data_offset to omit the start code
> prefix(0x000001). But some hardware video process do require the start code
> for AVS. The known device are those ARM chips from rockchips.
> 
> It would be not strip the start code for AVS to work in all the devices.

copy & pasting my reply from mailing list: https://lists.freedesktop.org/archives/libva/2016-September/004340.html

It is right that VA spec requires start code prefix, but AFAIK 
vaapi-intel-driver can work even if middleware doesn't  insert start code..
From gstreamer-vaapi side, we are not sending SC for both avc and hevc, 
and we use a single code path for both
stream-formats (avc and avc_bytestream , hevc and hevc_bytestream).

We can make it compliant with the spec , but more code change requires 
for non-bytestream format.
I mean, we have to explicitly insert the SC prefix for non-bytestream 
formats of AVC and HEVC.

BTW, H264 is AVC, not AVS :)
Comment 2 Randy Li (ayaka) 2016-09-01 09:25:59 UTC
OK, you could assign this issue to me, I would like to submit patches in the future time.
Comment 3 GStreamer system administrator 2018-11-03 15:48:20 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/44.