After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770663 - add build/run shortcuts to keyboard shortcuts window
add build/run shortcuts to keyboard shortcuts window
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: keybindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-31 17:27 UTC by Christian Hergert
Modified: 2016-09-10 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remaining key bindings added (29.10 KB, image/png)
2016-09-05 09:30 UTC, Ekta Nandwani 		  Details
Add Build and Run keybindings to Shortcut window (512.78 KB, patch)
2016-09-05 10:09 UTC, Ekta Nandwani 		none Details | Review
Add Build and Run keybindings to Shortcut window (2.07 KB, patch)
2016-09-05 10:47 UTC, Ekta Nandwani 		committed Details | Review

Description Christian Hergert 2016-08-31 17:27:26 UTC 
We are missing a few keybindings from our shortcuts window. We need to add

 Build (Ctrl+F7)
 Run (Ctrl+F5)
 Profile (Ctrl+F8)

We might want these in a new section for building, but I'll leave it up to the person doing this bug to come up with the right answer there. Our shortcuts window is already a bit too tall for small screens as it is.
Comment 1 Ekta Nandwani 2016-09-05 09:30:41 UTC 
Created attachment 334775 [details]
Remaining key bindings added

Will this work as a solution for the bug?
Comment 2 Ekta Nandwani 2016-09-05 10:09:33 UTC 
Created attachment 334779 [details] [review]
Add Build and Run keybindings to Shortcut window
Comment 3 Ekta Nandwani 2016-09-05 10:47:16 UTC 
Created attachment 334781 [details] [review]
Add Build and Run keybindings to Shortcut window

The previous patch contained unnecessary file changes. Sorry for that.
Comment 4 Christian Hergert 2016-09-10 16:44:53 UTC 
Review of attachment 334781 [details] [review]:

LGTM, thanks!
Comment 5 Christian Hergert 2016-09-10 16:45:46 UTC 
Attachment 334781 [details] pushed as afac599 - Add Build and Run keybindings to Shortcut window