After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770652 - Fix compiler warning
Fix compiler warning
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-31 14:45 UTC by Dominique Leuenberger
Modified: 2016-09-02 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix compiler warning (822 bytes, patch)
2016-08-31 14:45 UTC, Dominique Leuenberger 		committed Details | Review

Description Dominique Leuenberger 2016-08-31 14:45:10 UTC 
The final return should not be reachable - but there is no way for
the compiler to know

Just return 0 as last fallback
Comment 1 Dominique Leuenberger 2016-08-31 14:45:14 UTC 
Created attachment 334536 [details] [review]
Fix compiler warning
Comment 2 Carlos Soriano 2016-08-31 14:54:59 UTC 
Review of attachment 334536 [details] [review]:

Hey, thanks for the patch!

This is actually code from https://github.com/swilmet/gnome-c-utils
Can you fix it there first and then we can copy paste the code here?
Comment 3 Dominique Leuenberger 2016-08-31 14:57:23 UTC 
(In reply to Carlos Soriano from comment #2)

> This is actually code from https://github.com/swilmet/gnome-c-utils
> Can you fix it there first and then we can copy paste the code here?

Of course - I didn't realize that this was imported code
Comment 4 Dominique Leuenberger 2016-08-31 15:02:59 UTC 
(In reply to Dominique Leuenberger from comment #3)
> (In reply to Carlos Soriano from comment #2)
> 
> > This is actually code from https://github.com/swilmet/gnome-c-utils
> > Can you fix it there first and then we can copy paste the code here?
> 
> Of course - I didn't realize that this was imported code

https://github.com/swilmet/gnome-c-utils/pull/2
Comment 5 Dominique Leuenberger 2016-08-31 19:12:24 UTC 
(In reply to Dominique Leuenberger from comment #4)
> (In reply to Dominique Leuenberger from comment #3)
> > (In reply to Carlos Soriano from comment #2)
> > 
> > > This is actually code from https://github.com/swilmet/gnome-c-utils
> > > Can you fix it there first and then we can copy paste the code here?
> > 
> > Of course - I didn't realize that this was imported code
> 
> https://github.com/swilmet/gnome-c-utils/pull/2

Upstream merged as
https://github.com/swilmet/gnome-c-utils/commit/9c3b1d3ef80b32adf9b185d9a2226417795d78da
Comment 6 Carlos Soriano 2016-09-01 07:38:35 UTC 
Excellent, thanks a lot!

*** This bug has been marked as a duplicate of bug 766174 ***
Comment 7 Carlos Soriano 2016-09-01 07:39:14 UTC 
Review of attachment 334536 [details] [review]:

Looks good now, thanks!
Comment 8 Dominique Leuenberger 2016-09-01 07:42:51 UTC 
Attachment 334536 [details] pushed as 2f0a954 - Fix compiler warning
Comment 9 Sébastien Wilmet 2016-09-02 10:34:02 UTC 
Nautilus could have a script update-lineup-parameters.sh that:
- downloads the latest version with wget or curl for example;
- adds a comment at the top, like:

/* Do not edit: this file is downloaded from <...> */
Comment 10 Carlos Soriano 2016-09-02 11:53:47 UTC 
(In reply to Sébastien Wilmet from comment #9)
> Nautilus could have a script update-lineup-parameters.sh that:
> - downloads the latest version with wget or curl for example;
> - adds a comment at the top, like:
> 
> /* Do not edit: this file is downloaded from <...> */

That's true, however I'm not sure about requiring internet access when building nautilus, and instead I would like to still have this built on make
Comment 11 Sébastien Wilmet 2016-09-02 12:00:00 UTC 
It's a script that only the maintainer would run from time to time, not automatically. There would still be the copy of the file in the git repo.