After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770615 - Tarball is missing test data
Tarball is missing test data
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-08-30 22:04 UTC by Gilles Dartiguelongue
Modified: 2016-11-03 22:25 UTC
See Also:
GNOME target: ---
GNOME version: 3.19/3.20

Attachments
0001-Add-missing-test-data-to-distribution.patch (894 bytes, patch)
2016-08-30 22:04 UTC, Gilles Dartiguelongue 		committed Details | Review
0002-Enable-atk-test-when-running-make-distcheck.patch (550 bytes, patch)
2016-08-30 22:06 UTC, Gilles Dartiguelongue 		committed Details | Review

Description Gilles Dartiguelongue 2016-08-30 22:04:38 UTC 
Created attachment 334486 [details] [review]
0001-Add-missing-test-data-to-distribution.patch

When building at-spi2-atk with --with-tests=yes, unittests fail due to missing xml files in tests/data/

This applies to 3.20 tarballs as well as current master.
Comment 1 Gilles Dartiguelongue 2016-08-30 22:06:51 UTC 
Created attachment 334487 [details] [review]
0002-Enable-atk-test-when-running-make-distcheck.patch

Enable unittests when running make distcheck. This should catch this kind of error when preparing release tarballs. Do note that it might require having a running dbus-session. I tested this locally with:
$ dbus-run-session make distcheck
Comment 2 Gilles Dartiguelongue 2016-11-01 17:21:09 UTC 
Guys, 2.22 is the fourth release in a row with this problem, could you please review these patches ?
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2016-11-02 09:08:15 UTC 
Review of attachment 334486 [details] [review]:

LGTM
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2016-11-02 09:08:21 UTC 
Review of attachment 334487 [details] [review]:

LGTM
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2016-11-02 09:08:46 UTC 
(In reply to Gilles Dartiguelongue from comment #2)
> Guys, 2.22 is the fourth release in a row with this problem, could you
> please review these patches ?

Sorry for the late review. Thanks for the patches and the ping.
Comment 6 Mike Gorse 2016-11-03 21:24:52 UTC 
Comment on attachment 334486 [details] [review]
0001-Add-missing-test-data-to-distribution.patch

Pushed to master: 710e1e
Comment 7 Mike Gorse 2016-11-03 21:26:12 UTC 
Comment on attachment 334487 [details] [review]
0002-Enable-atk-test-when-running-make-distcheck.patch

Pushed to master: a9d9f6
Comment 8 Mike Gorse 2016-11-03 21:27:07 UTC 
Patches committed. I apologize for the long delay.
Comment 9 Gilles Dartiguelongue 2016-11-03 22:25:38 UTC 
Getting it fixed in the hand is more important to me than the delay don't worry :)
Thanks for your time.