After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770612 - new cryptsetup integration with gdm breaks non-luks use cases
new cryptsetup integration with gdm breaks non-luks use cases
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-30 20:12 UTC by Ray Strode [halfline]
Modified: 2016-08-30 20:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pam_gdm: return AUTHINFO_UNAVAIL if kernel keyring unavailable (2.05 KB, patch)
2016-08-30 20:13 UTC, Ray Strode [halfline] 		committed Details | Review
pam: don't call into pam_unix if pam_gdm fails for autolgoin (2.34 KB, patch)
2016-08-30 20:13 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2016-08-30 20:12:58 UTC 
I didn't quite get the pam stuff right, so if a user doesn't have LUKS things
go wrong.

See attached patches for a proposed solution.
Comment 1 Ray Strode [halfline] 2016-08-30 20:13:04 UTC 
Created attachment 334483 [details] [review]
pam_gdm: return AUTHINFO_UNAVAIL if kernel keyring unavailable

right now we return PAM_SUCCESS if keyutils are unavailable.
This is the wrong default, we should fail if we aren't able to
get the password.
Comment 2 Ray Strode [halfline] 2016-08-30 20:13:08 UTC 
Created attachment 334484 [details] [review]
pam: don't call into pam_unix if pam_gdm fails for autolgoin

If pam_gdm fails we shouldn't call into pam_unix since it can lead
to the system asking for a password, and autologin isn't equipped for
that.

This commit changes the pam configuration to jump to pam_permit if
pam_gdm fails.
Comment 3 Ray Strode [halfline] 2016-08-30 20:42:34 UTC 
Attachment 334483 [details] pushed as bb12416 - pam_gdm: return AUTHINFO_UNAVAIL if kernel keyring unavailable
Attachment 334484 [details] pushed as aa7fbd9 - pam: don't call into pam_unix if pam_gdm fails for autolgoin