Created attachment 334452 [details] [review]
file-operations: open unsupported archives in another application

The library used for managing compressed files does not yet support all use
cases such as encrypted archives. In order to fix this, attempt to open
unsupported archives in other applications.

Review of attachment 334452 [details] [review]:

::: src/nautilus-file-operations.c
@@ +8264,3 @@
     source_file = autoar_extractor_get_source_file (extractor);
 
+    if (IS_IO_ERROR (error, NOT_SUPPORTED))

you have to abort the job too, no?

::: src/nautilus-operations-ui-manager.c
@@ +528,3 @@
+    if (application)
+    {
+        GtkWidget *dialog;

autoptr?

@@ +539,3 @@
+    return FALSE;
+}
+                                                              GTK_DIALOG_MODAL |

Add a comment here why we need this.
Also add some prefix. "handle_unsuppoirted_file" looks too generic to not clash with a different "handle_unsuported_file", being in a public API. How about handle_unsupported_compressed_file?

Created attachment 334458 [details] [review]
file-operations: open unsupported archives in another application

The library used for managing compressed files does not yet support all use
cases such as encrypted archives. In order to fix this, attempt to open
unsupported archives in other applications.

Review of attachment 334458 [details] [review]:

Just some nitpicks.

::: src/nautilus-operations-ui-manager.c
@@ +500,3 @@
+{
+    HandleUnsupportedFileData *data;
+} HandleUnsupportedFileData;

initialize to NULL

@@ +509,3 @@
+    {
+        GtkWidget *dialog;
+    HandleUnsupportedFileData *data;

initialize to null

@@ +528,3 @@
+    if (application)
+    {
+        GtkWidget *dialog;

to nULL

@@ +535,3 @@
+    }
+
+

use G_SOURCE_* constants.

Created attachment 334460 [details] [review]
file-operations: open unsupported archives in another application

The library used for managing compressed files does not yet support all use
cases such as encrypted archives. In order to fix this, attempt to open
unsupported archives in other applications.

Review of attachment 334460 [details] [review]:

perfect, thanks!

Attachment 334460 [details] pushed as 1686ce8 - file-operations: open unsupported archives in another application