After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770574 - Fix reporting bridge being disabled
Fix reporting bridge being disabled
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-08-29 18:56 UTC by Samuel Thibault
Modified: 2016-08-29 20:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (347 bytes, patch)
2016-08-29 18:56 UTC, Samuel Thibault 		committed Details | Review

Description Samuel Thibault 2016-08-29 18:56:40 UTC 
Created attachment 334401 [details] [review]
proposed fix

Hello,

We have had a report of systematic java startup crashes:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824226#22

Investigation has shown that in his environment, the accessibility bus 
does not work for some reason. But that should not make Java applications 
crash. It happens that java-atk-wrapper does not really check that the 
at-spi initialization really went fine (or was disabled). When later 
java-atk-wrapper calls at-spi functions, horrible things can happen.

In the patch proposed here, atk_bridge_adaptor_init is made to return -1
also when the bridge is disabled, to avoid letting java think it 
initialized fine.

Samuel
Comment 1 Mike Gorse 2016-08-29 20:54:01 UTC 
Looks okay to me.
Pushed to master: 1cff8f

Thanks for the patch.