After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770550 - gtkplacessidebar: fix signal marshal
gtkplacessidebar: fix signal marshal
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 771083 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-08-29 13:01 UTC by Carlos Soriano
Modified: 2016-09-12 08:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkplacessidebar: fix signal marshal (1.23 KB, patch)
2016-08-29 13:01 UTC, Carlos Soriano 		committed Details | Review

Description Carlos Soriano 2016-08-29 13:01:10 UTC 
.
Comment 1 Carlos Soriano 2016-08-29 13:01:15 UTC 
Created attachment 334362 [details] [review]
gtkplacessidebar: fix signal marshal

We were using __VOID for the SHOW_OTHER_LOCATION signal that
uses flags named SHOR_OTHER_LOCATION_WITH_FLAGS.
However, if a signal uses flags the marshal needs to use __FLAGS.

This patch addresses this using VOID__FLAGS as the marshaler parameter.

Thanks to Jan Steffens for pointing this out.
Comment 2 Carlos Soriano 2016-08-29 13:06:30 UTC 
Reviewed on IRC by Jan Steffens

Attachment 334362 [details] pushed as cfe4c9e - gtkplacessidebar: fix signal marshal
Comment 3 Carlos Soriano 2016-09-12 08:14:58 UTC 
*** Bug 771083 has been marked as a duplicate of this bug. ***