After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770507 - Use templates for glib-mkenums
Use templates for glib-mkenums
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-28 12:12 UTC by Ernestas Kulik
Modified: 2016-09-01 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use templates for glib-mkenums (5.29 KB, patch)
2016-08-28 12:12 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2016-08-28 12:12:34 UTC
Currently, enum types are generated by passing command line
arguments to glib-mkenums. A better alternative to that is passing a
template file, which also declutters build files.
Comment 1 Ernestas Kulik 2016-08-28 12:12:39 UTC
Created attachment 334302 [details] [review]
Use templates for glib-mkenums
Comment 2 Carlos Soriano 2016-09-01 09:31:50 UTC
Review of attachment 334302 [details] [review]:

Checked what gedit does, and seems is pretty similar. I agree this looks better, so LGTM. Thanks for it!
Comment 3 Ernestas Kulik 2016-09-01 15:03:30 UTC
Attachment 334302 [details] pushed as 437f573 - Use templates for glib-mkenums