GNOME Bugzilla – Bug 770490
Add extra clone on the left.
Last modified: 2016-09-03 10:20:01 UTC
Created attachment 334277 [details] Markers without left clone not rendering properly. I've noticed this in Maps: Go_to animation makes the viewport hover over the original layer only (which is on the left) so this exposes some empty space on the left. An additional clone on the left side makes the go_to animation seamless and fills the empty space. This also solves a small issue with markers that span over the right border of the map not rendering. (I've attached a screenshot to illustrate the issue).
Created attachment 334278 [details] [review] Attachment to Bug 770490 - Add extra clone on the left. Add extra clone on the left.
Thanks Marius, I'll have a look at it tomorrow.
Looks good. There's just one minor problem - when I set the New York marker to the position like in your picture so it's only partially visible on the left, I cannot drag it. I think the user layer swapping needs some update too to take into account the last actor belongs to the left.
Created attachment 334636 [details] [review] Add extra clone on the left. This makes the go_to animation smoother (no more empty space on the left) and also fixes a rendering issue with markers crossing the right border of the map.
Fixed! I missed the swapping indeed, thanks for looking into it.
Thanks, looks good now. Merged. Also having the left clone at the beginning of the clone list is cleaner than having it at the end.
By the way, I just remembered - have you asked the clutter guys about the clone "bug" and the cairo guys about the strange "rounding" issue with path layer and high zoom levels? Would be interesting to know more.