After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770478 - rhythmbox and rhythmbox-client bash auto completions
rhythmbox and rhythmbox-client bash auto completions
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: Documentation
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-27 12:26 UTC by gnome.vrb
Modified: 2018-05-24 19:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rhythmbox and rhythmbox-client bash auto completions (1.42 KB, text/plain)
2016-08-27 12:26 UTC, gnome.vrb
  Details
Bash auto completions for rhythmbox and rhythmbox-client (2.51 KB, patch)
2016-11-15 18:50 UTC, gnome.vrb
none Details | Review
Bash auto completions for rhythmbox and rhythmbox-client (2.53 KB, patch)
2016-11-15 20:02 UTC, gnome.vrb
none Details | Review

Description gnome.vrb 2016-08-27 12:26:24 UTC
Created attachment 334269 [details]
rhythmbox and rhythmbox-client bash auto completions

Attached the file.

This file needs to be installed in /etc/bash_completion.d/ with normal permissions ( 644 ). Not sure on how to do that.
Comment 1 Jonathan Matthew 2016-08-28 03:15:14 UTC
According to the bash-completion readme file, they should go in the directory indicated by the completionsdir variable in the bash-completion pkg-config file, rather than /etc/bash_completion.d/.  It looks like gnome-control-center installs a completion file there, so maybe look there to see how to do it.

It looks like there's a helper function that parses the output of whateverprogram --help and uses that for completion, which would be a much better idea than having a list of arguments in the completion helper.  I'm not going to keep this stuff up to date because I dislike bash-completion and never use it, so not having to update it as arguments change would help.
Comment 2 gnome.vrb 2016-08-28 03:52:04 UTC
(In reply to Jonathan Matthew from comment #1)
> According to the bash-completion readme file, they should go in the
> directory indicated by the completionsdir variable in the bash-completion
> pkg-config file, rather than /etc/bash_completion.d/.  It looks like
> gnome-control-center installs a completion file there, so maybe look there
> to see how to do it.

Will do that.

> It looks like there's a helper function that parses the output of
> whateverprogram --help and uses that for completion, which would be a much
> better idea than having a list of arguments in the completion helper.  I'm
> not going to keep this stuff up to date because I dislike bash-completion
> and never use it, so not having to update it as arguments change would help.

Since rhythmbox is a music player, we could possibly add content type filtering ( mp3 / ogg / pls / m3u / xspf ). So, I would prefer to keep the options open and stay manual.
Comment 3 Jonathan Matthew 2016-08-28 08:39:00 UTC
(In reply to vrishab from comment #2)
> Since rhythmbox is a music player, we could possibly add content type
> filtering ( mp3 / ogg / pls / m3u / xspf ). So, I would prefer to keep the
> options open and stay manual.

I don't think the --help auto completion stops you from doing that.
Comment 4 gnome.vrb 2016-11-15 18:50:17 UTC
Created attachment 339958 [details] [review]
Bash auto completions for rhythmbox and rhythmbox-client
Comment 5 gnome.vrb 2016-11-15 20:02:59 UTC
Created attachment 339960 [details] [review]
Bash auto completions for rhythmbox and rhythmbox-client

Use pkg-config to get completions dir.
Comment 6 GNOME Infrastructure Team 2018-05-24 19:01:01 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1489.