After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770468 - gamepad: Several annoying bugs
gamepad: Several annoying bugs
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-27 07:12 UTC by Adrien Plazas
Modified: 2016-08-27 07:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gamepad: Check mapping on standard button events (1.65 KB, patch)
2016-08-27 07:12 UTC, Adrien Plazas
committed Details | Review
gamepad: Add RawGamepad.standard_axis_event() signal (976 bytes, patch)
2016-08-27 07:12 UTC, Adrien Plazas
committed Details | Review
gamepad: Forward standard axis events (1.30 KB, patch)
2016-08-27 07:12 UTC, Adrien Plazas
committed Details | Review
gamepad: Add LinuxRawGamepad.centered_axis_value() (2.13 KB, patch)
2016-08-27 07:12 UTC, Adrien Plazas
committed Details | Review
gamepad: Make LinuxRawGamepad send standard axis events (2.21 KB, patch)
2016-08-27 07:12 UTC, Adrien Plazas
committed Details | Review

Description Adrien Plazas 2016-08-27 07:12:13 UTC
Gamepads have several annoying bugs:
- standard gamepad button events aren't mapped
- standard axis events aren't forwarded without a mapping
- gamepad axes with an exotic range don't work
Comment 1 Adrien Plazas 2016-08-27 07:12:34 UTC
Created attachment 334256 [details] [review]
gamepad: Check mapping on standard button events

This avoids standard button events to be handled two times if the
gamepad has a mapping while allowing to map any event.
Comment 2 Adrien Plazas 2016-08-27 07:12:40 UTC
Created attachment 334257 [details] [review]
gamepad: Add RawGamepad.standard_axis_event() signal

This will be used in the next commits to let the gamepads forward the
well formed axis events.
Comment 3 Adrien Plazas 2016-08-27 07:12:45 UTC
Created attachment 334258 [details] [review]
gamepad: Forward standard axis events

This allow standard axis events to be handled by gamepads without a
mapping.
Comment 4 Adrien Plazas 2016-08-27 07:12:50 UTC
Created attachment 334259 [details] [review]
gamepad: Add LinuxRawGamepad.centered_axis_value()

This allows to properly compute the value of axis event's value even if
its range is different from [-abs_info.maximum:abs_info.maximum].
Comment 5 Adrien Plazas 2016-08-27 07:12:55 UTC
Created attachment 334260 [details] [review]
gamepad: Make LinuxRawGamepad send standard axis events

This allow gamepads with not mapping but sending proper gamepad events
to work as intended.
Comment 6 Adrien Plazas 2016-08-27 07:14:20 UTC
Attachment 334256 [details] pushed as d14b06c - gamepad: Check mapping on standard button events
Attachment 334257 [details] pushed as 4b4e509 - gamepad: Add RawGamepad.standard_axis_event() signal
Attachment 334258 [details] pushed as d971c23 - gamepad: Forward standard axis events
Attachment 334259 [details] pushed as 946937a - gamepad: Add LinuxRawGamepad.centered_axis_value()
Attachment 334260 [details] pushed as f548297 - gamepad: Make LinuxRawGamepad send standard axis events