After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770421 - incorrect (out) annotation for gtk_text_iter_get_attributes
incorrect (out) annotation for gtk_text_iter_get_attributes
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Language Bindings
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-08-26 01:00 UTC by Phil Clayton
Modified: 2018-05-02 17:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix annotation for gtk_text_iter_get_attributes (882 bytes, patch)
2016-08-26 01:11 UTC, Phil Clayton 		reviewed Details | Review

Description Phil Clayton 2016-08-26 01:00:28 UTC 
The argument @values of gtk_text_iter_get_attributes has an (out) annotation but I believe that it should be (in).  The gtk-doc comment says that @values is modified by the function, i.e. not entirely written.  The (out) annotation will cause certain language bindings to provide no means to pass a value in for @values.
Comment 1 Patrick Griffis (tingping) 2016-08-26 01:07:45 UTC 
Sounds like (out caller-allocates) which still makes it unusable from most language bindings.
Comment 2 Phil Clayton 2016-08-26 01:11:23 UTC 
Created attachment 334195 [details] [review]
Fix annotation for gtk_text_iter_get_attributes
Comment 3 Phil Clayton 2016-08-26 01:26:19 UTC 
Given one level of indirection in the @values argument, I agree that the only valid (out) interpretation would be as an (out caller-allocates).  That probably explains why it hasn't been picked up.
Comment 4 Christoph Reiter (lazka) 2017-03-30 08:28:24 UTC 
Review of attachment 334195 [details] [review]:

lgtm, for what it's worth
Comment 5 GNOME Infrastructure Team 2018-05-02 17:26:56 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/662.