After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770408 - dashdemux: Add properties to select maximum allowed width/height and framerate
dashdemux: Add properties to select maximum allowed width/height and framerate
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal enhancement
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-25 17:52 UTC by Sebastian Dröge (slomo)
Modified: 2016-08-26 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dashdemux: Add properties to select maximum allowed width/height and framerate (9.38 KB, patch)
2016-08-25 17:53 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-08-25 17:52:56 UTC 
See commit
Comment 1 Sebastian Dröge (slomo) 2016-08-25 17:53:02 UTC 
Created attachment 334163 [details] [review]
dashdemux: Add properties to select maximum allowed width/height and framerate
Comment 2 Tim-Philipp Müller 2016-08-25 18:02:45 UTC 
That's been requested a few times, also for HLS though.
Comment 3 Sebastian Dröge (slomo) 2016-08-26 07:09:25 UTC 
You think it would be better to move all these properties to the base class? IMHO it feels more like a concern for the subclass as not every format might have these possibilities.
Comment 4 Tim-Philipp Müller 2016-08-26 13:55:19 UTC 
Right, there's no way for the base class to make that decision currently anyway, is there?

So let's get that in and then clone this bug for hlsdemux (where it might be trickier because we can't be guaranteed the info is available in the playlist I think, but we should at least exclude streams if it is available).

API looks fine. Only alternative API I can think of is a) some kind of restriction caps where we ignore the media type, and just intersect/subset-check the width/height/framerate fields, and b) some signal/callback based API.

I think this is best though. Easy and discoverable. KISS.
Comment 5 Sebastian Dröge (slomo) 2016-08-26 15:12:46 UTC 
commit 4734b10c6f7ed83cbd6be5f3b3c16aab8ca2b49b
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Aug 25 20:50:11 2016 +0300

    dashdemux: Add properties to select maximum allowed width/height and framerate
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770408