After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770388 - GtkTreeView: attempt to underallocate GtkTreeView's child GtkButton
GtkTreeView: attempt to underallocate GtkTreeView's child GtkButton
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: .General
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 765596 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-08-25 12:59 UTC by Christoph Reiter (lazka)
Modified: 2018-04-15 00:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
treeview: Don't underallocate drag button (1.40 KB, patch)
2016-09-25 07:46 UTC, Timm Bäder
none Details | Review
treeviewcolumn: don't underallocate column headers (1.33 KB, patch)
2016-09-25 07:47 UTC, Timm Bäder
none Details | Review
widget: Don't print underallocation warnings by default (1.14 KB, patch)
2016-09-27 09:45 UTC, Christoph Reiter (lazka)
committed Details | Review

Description Christoph Reiter (lazka) 2016-08-25 12:59:12 UTC
I get lots of warnings with gtk+ master.

The warning can be reproduced using gtk3-demo:

$ gtk3-demo --run=tree_store

(gtk3-demo:6100): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to underallocate GtkButton's child GtkBox 0x1d59430. Allocation is 37x24, but minimum required size is 41x14.

(gtk3-demo:6100): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to underallocate GtkTreeView's child GtkButton 0x1bc0340. Allocation is 50x25, but minimum required size is 55x25.

(gtk3-demo:6100): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to underallocate GtkTreeView's child GtkButton 0x1dbd180. Allocation is 50x25, but minimum required size is 54x25.
Comment 1 gnome.vrb 2016-08-31 18:40:27 UTC
They are too many of these in many gtk apps. Is there a way to disable them for now ?
Comment 2 Matthias Clasen 2016-09-05 01:48:58 UTC
The warning in gtk3-demo --run=tree_store were caused by fixed column widths. I've fixed that now.
Comment 3 Christoph Reiter (lazka) 2016-09-05 04:48:03 UTC
My application uses fixed column widths. This was just meant as a way to reproduce.
Comment 4 Christoph Reiter (lazka) 2016-09-25 07:03:07 UTC
Can this warning be disabled for the stable release?

Getting multiple pages of warnings on each redraw is annoying.
Comment 5 Timm Bäder 2016-09-25 07:46:42 UTC
Created attachment 336207 [details] [review]
treeview: Don't underallocate drag button
Comment 6 Timm Bäder 2016-09-25 07:47:02 UTC
Created attachment 336208 [details] [review]
treeviewcolumn: don't underallocate column headers
Comment 7 Timm Bäder 2016-09-25 07:48:05 UTC
Can you apply those patches and still reproduce? They are just fixing some obvious problems. I usually don't do treeviews.
Comment 8 Christoph Reiter (lazka) 2016-09-25 08:07:31 UTC
Thanks. With both patches applied the warning is gone.

But the right hand side borders of the columns are gone now when the label widget is truncated.
Comment 9 Timm Bäder 2016-09-25 10:15:24 UTC
Yeah, dunno what to do about that, the borders are drawn by the button and that just has a minimum size... unless we set the minimum width of the column to that of the button of course, but I guess that's not an option.
Comment 10 Christoph Reiter (lazka) 2016-09-25 10:41:22 UTC
I guess the border could be drawn by the next column?

I just noticed that the above patches break things in RTL mode
Comment 12 Matthias Clasen 2016-09-30 18:41:26 UTC
Comment on attachment 336324 [details] [review]
widget: Don't print underallocation warnings by default

Attachment 336324 [details] pushed as ae8ffc7 - widget: Don't print underallocation warnings by default
Comment 13 Matthias Clasen 2018-02-10 05:15:59 UTC
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
Comment 14 Timm Bäder 2018-02-10 12:34:31 UTC
*** Bug 765596 has been marked as a duplicate of this bug. ***
Comment 15 Matthias Clasen 2018-04-15 00:07:51 UTC
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla.

If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab:

https://gitlab.gnome.org/GNOME/gtk/issues/new